Fix saving vote for post/discussion created by deleted user#145
Merged
DavideIadeluca merged 1 commit intoFriendsOfFlarum:1.xfrom Mar 18, 2026
Merged
Fix saving vote for post/discussion created by deleted user#145DavideIadeluca merged 1 commit intoFriendsOfFlarum:1.xfrom
DavideIadeluca merged 1 commit intoFriendsOfFlarum:1.xfrom
Conversation
DavideIadeluca
approved these changes
Mar 18, 2026
Member
|
Thanks @rob006. Tagged as v1.6.12. Might you be able to open a 2.x PR for this issue as well? |
Contributor
Author
|
I don't have an environment to test this on 2.x, but I suspect that 2.x is not affected by this bug - this param is not present in 2.x version: gamification/src/Api/PostResourceFields.php Line 119 in ac28834 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an error when someone is trying to vote on discussion created by user, that was deleted.