[TASK] Refactor command input handling and remove redundant validators#197
Merged
[TASK] Refactor command input handling and remove redundant validators#197
Conversation
The Decorators no longer instantiate Normalizers to avoid duplicate work. Specialized validators (Command, Controller, Event, etc.) have been removed in favor of calling ClassNameValidator directly. Since the Normalizer now ensures the correct suffixes are present before validation occurs, the suffix-specific checks are no longer required.
Collaborator
Author
|
Relates to PR: #171 |
simonschaufi
approved these changes
Feb 9, 2026
Collaborator
simonschaufi
left a comment
simonschaufi
left a comment
There was a problem hiding this comment.
I like your improvements!
Collaborator
Author
|
@simonschaufi Thank you, but be careful. Now, the default value for various classname questions is just "DoSomething" and not "DoSomethingCommand" anymore. I don't think that this is an issue. Nevertheless the "Command" will automatically be applied, if not already given...but hidden for the user. Only with last confirmation the user will see, that we have added the "needed" suffix to the class- and filename. What do you think? Still OK? |
Collaborator
That is absolutely fine for me. |
Collaborator
|
I hope you will also add some tests later on 😄 |
Collaborator
Author
|
I have written you via Slack |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Decorators no longer instantiate Normalizers to avoid duplicate work. Specialized validators (Command, Controller, Event, etc.) have been removed in favor of calling ClassNameValidator directly.
Since the Normalizer now ensures the correct suffixes are present before validation occurs, the suffix-specific checks are no longer required.