Conversation
Not tested (obviously), hope the unit tests are good enough.
|
Fix tests and then retry a PR |
|
I am sorry but it looks like it is your travis configuration who leads to failures. And I need it done quickly because, even if it might surprise you, the project I am currently working on depends on Confiture. |
|
Nics, The Confiture development team |
|
Frky, Half of the population using Confiture. |
|
You just proved me I was right not accepting your dumbed PR - cf commit dfc449e. |
|
Don't brag too much about it, you may lose instantly around 50,0% of all the active contributors on this project. P.S.: Your link is broken, maybe you wanted to show me this : dfc449e ? |
|
YOUR link is broken. |
|
Overwriting my comment (and yours) just to discredit me ? That's a childish attitude from you, sir. I expected more from a project's maintainer. |
|
You know what : I give up. I will change Confiture locally and distribute my modified version directly with my project source code. I feel lucky the MIT licence allows it. |
|
Running away from problems is not the solution. |
|
I am not running away, I am getting around it. |
|
Hello guys, I'm working on a project that can send people into space and we absolutely need to have this PR merged. The coffee machine depends on you. |
Not tested (obviously), hope the unit tests are good enough.