-
Notifications
You must be signed in to change notification settings - Fork 0
Migrate forc-tracing & forc-crypto over from the sway repo.
#119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR SummaryAdds forc-crypto (CLI) and forc-tracing (library) to the workspace, updates docs/deps, and makes the release CI skip building binaries for library-only crates.
Written by Cursor Bugbot for commit 828642f. This will update automatically on new commits. Configure here. |
- Fix forc-tracing tests to check for escaped ANSI codes - Add binary detection to CI to skip builds for library-only crates - Add CHANGELOG.md for forc-tracing and forc-crypto - Update RELEASING.md with new workspace members
3cda65d to
fbdab0b
Compare
forc-tracing & forc-crypto over from the sway repo.forc-tracing & forc-crypto over from the sway repo.
| forc-tracing = "0.70.2" | ||
| fuels = "0.75" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
qq: is there a reason not to use workspace for all deps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this was based off our discussion that we had last week. Ideally, we'll move towards having workspace deps for fuel crates, but for the initial migration, we'll keep them separate.
## Summary - forc-crypto migrated from `FuelLabs/sway` to `FuelLabs/forc` monorepo at v0.71.0 - Add version-based repository routing using the same `legacy_repo`/`legacy_before` pattern established for forc-wallet in #204 - Add `buildAndTestSubdir` patch for forc-crypto when built from forc monorepo ## Changes **refresh-manifests.sh:** - Versions < 0.71.0: fetch from sway repo with `v{version}` tags - Versions >= 0.71.0: fetch from forc monorepo with `forc-crypto-{version}` tags **patches.nix:** - Add patch setting `buildAndTestSubdir = "forc-crypto"` when built from forc monorepo **packages.md:** - Update forc-crypto documentation to reference forc repo ## Context - forc-crypto migration PR: FuelLabs/forc#119 - forc-crypto v0.71.0 release: https://github.com/FuelLabs/forc/releases/tag/forc-crypto-0.71.0 - sway-nightly-binaries update: FuelLabs/sway-nightly-binaries#79 --------- Co-authored-by: GitHub Action <action@github.com>
## Summary This PR completes the sway-side of migrating `forc-tracing` and `forc-crypto` to the new [forc monorepo](https://github.com/FuelLabs/forc), as outlined in [RFC #49](FuelLabs/sway-rfcs#49). The corresponding forc repo PR: FuelLabs/forc#119 ### Changes - Remove `forc-tracing` crate from workspace (now uses crates.io `0.71.1`) - Remove `forc-crypto` crate from workspace - Update CI to no longer build/package `forc-crypto` binary (it's now built from forc repo) - Update gh-pages workflow to install `forc-crypto` from forc repo for documentation generation ### Distribution Going forward, `forc-crypto` will be built and distributed from the forc repo by: - sway-nightly-binaries - fuelup - fuel.nix ### Documentation For now, documentation for all tooling will continue to live in this repo. The `gh-pages` workflow now pulls `forc-crypto` from the forc repo rather than building it locally, so docs generation continues to work as before.
Summary
Migrates
forc-tracingandforc-cryptofrom the sway repository into the forc monorepo, continuing the toolchain consolidation effort from sway-rfcs#49.Changes
New Workspace Members
forc-tracing(within monorepo)forc-utilforcli_examples!macroCI Updates
Test Fixes
serial_testto prevent race conditions inforc-tracingtestsJSON_MODE_ACTIVEstate requiring serial executionPost-merge Tasks
forc-tracing-0.71.0,forc-crypto-0.71.0forc-cryptofrom this repoforc-cryptoforc-cryptofrom hereforc-tracingandforc-cryptofrom sway repoRelated
forc-walletrepository toforcmonorepo #1forc-walletmigration from standalone repo toforcmonorepo fuelup#807