Skip to content

Conversation

@JoshuaBatty
Copy link
Member

@JoshuaBatty JoshuaBatty commented Dec 9, 2025

Summary

  • Updates all channel TOML files to use simplified target naming for forc-wallet
  • Renames section headers and URL filenames from Rust triples to simplified format:
    • aarch64-unknown-linux-gnulinux_arm64
    • x86_64-unknown-linux-gnulinux_amd64
    • aarch64-apple-darwindarwin_arm64
    • x86_64-apple-darwindarwin_amd64
  • 1137 files updated with 4943 insertions/deletions

Notes

Validation

  • Verified renamed asset URLs exist and return HTTP 200
  • All TOML files pass syntax validation
  • Confirmed no old naming remains in forc-wallet sections

Closes #809
Related: #808
RFC: FuelLabs/sway-rfcs#49

@cursor
Copy link

cursor bot commented Dec 9, 2025

PR Summary

Renames forc-wallet target keys in channel TOMLs from Rust triples to simplified platform names (darwin/linux arm64/amd64) across channels, leaving URLs and other packages unchanged.

  • Channels/TOML:
    • Rename forc-wallet target section headers from Rust triples to simplified platform names:
      • aarch64-apple-darwindarwin_arm64
      • x86_64-apple-darwindarwin_amd64
      • aarch64-unknown-linux-gnulinux_arm64
      • x86_64-unknown-linux-gnulinux_amd64
    • Apply across nightly channel files (and other channel TOMLs) without altering referenced assets; URLs remain as originally published.
    • No changes to fuel-core/other packages beyond forc-wallet target key renames.

Written by Cursor Bugbot for commit 5d1367f. This will update automatically on new commits. Configure here.

@JoshuaBatty JoshuaBatty self-assigned this Dec 9, 2025
Copy link
Member

@kayagokalp kayagokalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this break existing fuelup parsing logic? I remember we have things like

pub fn from_host() -> Result<Self> {
but can't exactly remember if these target triple constructs are actually matched against these toml files we are modifying in this PR.

Even if it is going to break things we can merge it and fix fuelup parsing logic afterwards. As it is hard to assess if things will go down or not without actually making the change to the toml files being consumed

@JoshuaBatty
Copy link
Member Author

That's a great point, i'm going to look into that tomorrow and make sure this is handled correctly. Cheers!

@JoshuaBatty
Copy link
Member Author

Will this break existing fuelup parsing logic? I remember we have things like

pub fn from_host() -> Result<Self> {

but can't exactly remember if these target triple constructs are actually matched against these toml files we are modifying in this PR.
Even if it is going to break things we can merge it and fix fuelup parsing logic afterwards. As it is hard to assess if things will go down or not without actually making the change to the toml files being consumed

This is addressed now in this commit 1535007

thanks for pointing it out!

Update all channel TOML files to use the new simplified target naming
convention for forc-wallet:

- aarch64-unknown-linux-gnu → linux_arm64
- x86_64-unknown-linux-gnu → linux_amd64
- aarch64-apple-darwin → darwin_arm64
- x86_64-apple-darwin → darwin_amd64

This aligns with the forc-wallet release asset renaming and the
simplified naming convention adopted by the forc monorepo.

Note: fuel-core and fuel-core-keygen entries are intentionally
unchanged as their release assets have not been renamed.

Closes #809
Related: #808
RFC: FuelLabs/sway-rfcs#49
@JoshuaBatty JoshuaBatty force-pushed the josh/rename-forc-wallet-gh-pages branch from b2c59be to 5d1367f Compare December 11, 2025 06:21
@JoshuaBatty JoshuaBatty merged commit 191fa6d into gh-pages Dec 11, 2025
5 of 7 checks passed
@JoshuaBatty JoshuaBatty deleted the josh/rename-forc-wallet-gh-pages branch December 11, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants