-
Notifications
You must be signed in to change notification settings - Fork 150
fix: rename forc-wallet targets from Rust triples to simplified names #811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR SummaryRenames forc-wallet target keys in channel TOMLs from Rust triples to simplified platform names (darwin/linux arm64/amd64) across channels, leaving URLs and other packages unchanged.
Written by Cursor Bugbot for commit 5d1367f. This will update automatically on new commits. Configure here. |
kayagokalp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this break existing fuelup parsing logic? I remember we have things like
Line 35 in 40b4239
| pub fn from_host() -> Result<Self> { |
Even if it is going to break things we can merge it and fix fuelup parsing logic afterwards. As it is hard to assess if things will go down or not without actually making the change to the toml files being consumed
|
That's a great point, i'm going to look into that tomorrow and make sure this is handled correctly. Cheers! |
This is addressed now in this commit 1535007 thanks for pointing it out! |
2e36aad to
b2c59be
Compare
Update all channel TOML files to use the new simplified target naming convention for forc-wallet: - aarch64-unknown-linux-gnu → linux_arm64 - x86_64-unknown-linux-gnu → linux_amd64 - aarch64-apple-darwin → darwin_arm64 - x86_64-apple-darwin → darwin_amd64 This aligns with the forc-wallet release asset renaming and the simplified naming convention adopted by the forc monorepo. Note: fuel-core and fuel-core-keygen entries are intentionally unchanged as their release assets have not been renamed. Closes #809 Related: #808 RFC: FuelLabs/sway-rfcs#49
b2c59be to
5d1367f
Compare
Summary
aarch64-unknown-linux-gnu→linux_arm64x86_64-unknown-linux-gnu→linux_amd64aarch64-apple-darwin→darwin_arm64x86_64-apple-darwin→darwin_amd64Notes
fuel-coreandfuel-core-keygenentries are intentionally unchanged (their release assets have not been renamed)Nightly URLs fromUpdate: Nightly assets now use simplified naming after feat: use simplified target names for forc-wallet and forc-crypto releases sway-nightly-binaries#80 was mergedsway-nightly-binariesretain old naming in URLs since those assets haven't been renamed in that repoValidation
Closes #809
Related: #808
RFC: FuelLabs/sway-rfcs#49