fix(build-channel): add retry logic and fail on network errors #815
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build-channel script was silently skipping targets when network requests failed, resulting in incomplete channel TOML files with missing platform targets. This caused PRs #812, #813, #814 to have broken channel configurations with randomly missing targets.
Root Cause
The
write_documentfunction was handling network errors like this:This silently continued without the target, producing incomplete TOML files.
Changes
fetch_with_retry()helper with exponential backoff (3 retries, 1s/2s/4s delays)?forc-cryptoversion to PR description in update-channel workflow (was missing, only 4/5 packages were shown)