Skip to content

Update Readme to include Cocoapod installation #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andynovak12 wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −1
Open

Update Readme to include Cocoapod installation #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@ A data source for a `UITableView` or a `UICollectionView` can be constructed by

## Installation

The recommended way to add DataSource to your project is with [Carthage](https://github.com/Carthage/Carthage/releases/).
The recommended way to add DataSource to your project is with CocoaPods. Add `pod 'DataSource', :git => 'https://github.com/Fueled/DataSource.git'` to your Podfile and run `pod install`.
Copy link
Copy Markdown
Contributor

@leontiy leontiy Jul 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather us stay impartial and just include 2 subsections: ### Cocoapods and ### Carthage (in this order). The reason being, Carthage was recommended as an alternative to no dependency management. What do you think?

Copy link
Copy Markdown
Contributor

@Vadim-Yelagin Vadim-Yelagin Jul 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sebsections are a common practice and make it easier to find relevant information (compared to reading text paragraphs).
If you don't want to be impartial you can write ### CocoaPods (recommended) but I don't see a reason for doing that.


An alternative is to use [Carthage](https://github.com/Carthage/Carthage/releases/).
Add `github "Fueled/DataSource"` line to your Cartfile and proceed with your favorite way to update and integrate your Carthage dependencies.

## Example Project
Expand Down