Add the series index page #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
essential-randomness
requested changes
Nov 1, 2023
essential-randomness
requested changes
Nov 1, 2023
Rename `begunAt` to `startedAt` and `creators` to `authors`
essential-randomness
approved these changes
Nov 2, 2023
|
You're welcome!! I'm happy to help!! |
|
Just FYI, I made a further change by mocking the requests to AO3 rather than using the live pages (see: #54, and the library we use for this: https://mswjs.io/). No problem at all with your PR, one day we'll actually run the tests before submission and also document how to do this :) this was a good chance to have a sample PR for this. Once again, thank you so much for contributing. |
|
Knew I forgot to do something! I saw the mocks, but I forgot to download the page and register it before I made PR ready. Thank you for catching that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #36