Skip to content

Remove use of redis.multi #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rileyt-auctane wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove use of redis.multi #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3251281
Use block argument for redis multi
rileyt-auctane May 14, 2024
b9027ec
Remove multi entirely - Job.create does redis internally
rileyt-auctane May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 11 additions & 13 deletions lib/resque_cleaner.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,19 +124,17 @@ def requeue(clear_after_requeue=false, options={}, &block)
index = @limiter.start_index + i - requeued

value = redis.lindex(:failed, index)
redis.multi do
# no change needed to support ActiveJob
Job.create(queue||job['queue'], job['payload']['class'], *job['payload']['args'])

if clear_after_requeue
# remove job
# TODO: should use ltrim. not sure why i used lrem here...
redis.lrem(:failed, 1, value)
else
# mark retried
job['retried_at'] = Time.now.strftime("%Y/%m/%d %H:%M:%S")
redis.lset(:failed, @limiter.start_index+i, Resque.encode(job))
end
# no change needed to support ActiveJob
Job.create(queue||job['queue'], job['payload']['class'], *job['payload']['args'])

if clear_after_requeue
# remove job
# TODO: should use ltrim. not sure why i used lrem here...
redis.lrem(:failed, 1, value)
else
# mark retried
job['retried_at'] = Time.now.strftime("%Y/%m/%d %H:%M:%S")
redis.lset(:failed, @limiter.start_index+i, Resque.encode(job))
end

requeued += 1
Expand Down