replace mp3 with ogg and proper filetype recognition #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the sped up audio filetype with ogg using an ffmpeg wrapper since its better in quality with lower filesize and also has consistent offset unlike mp3 making timing way more accurate (low quality will now be 128bkps and high quality 192kbps)
I also fixed the filetype recognition to actually read the filetype rather than assuming the extension is accurate. (It's a bit janky with little and big endian but it works). Example map for when this would cause issues: https://osu.ppy.sh/beatmapsets/1347975
i had to update to fsharp 9 from 8 for it to work.
vs added some system references by itself, idk why