Skip to content

update for 16 cells and 4 temperature sensors, fix a couple typos #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
claytonasmith wants to merge 1 commit into
base: main
Choose a base branch
from
Open

update for 16 cells and 4 temperature sensors, fix a couple typos #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions documentation/tutorial.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,7 +569,7 @@ and count up.
// Print out all cell voltages:
for (uint8_t i=0; i<bms.get_num_cells(); i++) {
// Print each voltage with 3 decimal places
lcd.println(bms.get_cell_voltage(i, 3));
lcd.println(bms.get_cell_voltage(i), 3);
}


Expand Down Expand Up @@ -620,7 +620,7 @@ Temperatures can be requested as follows:
// Print out all temperatures:
for (uint8_t i=0; i<bms.get_num_ntcs(); i++) {
// Print each temp with 2 decimal places
lcd.println(bms.get_ntc_temperature(i, 2));
lcd.println(bms.get_ntc_temperature(i), 2);
}

Temperatures are always return in Celsius.
Expand Down
4 changes: 2 additions & 2 deletions options.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@

#define BMS_TIMEOUT 1000 // The longest time to wait, in milliseconds for a response

#define BMS_MAX_CELLS 8 // Preallocates this number of cells voltages in the array
#define BMS_MAX_NTCs 2 // Preallocates this number of temperatures in the array
#define BMS_MAX_CELLS 16 // Preallocates this number of cells voltages in the array
#define BMS_MAX_NTCs 4 // Preallocates this number of temperatures in the array
#define BMS_MAX_RX_DATA_LEN 64 // Preallocates this number of bytes to store RX data field


Expand Down