Skip to content

Throw a useful error when loading a classic theme page #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MatteoCampinoti94 merged 4 commits into from
Oct 29, 2025
Merged

Throw a useful error when loading a classic theme page #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
edaef75
Detect Classic theme and raise error
plum-pan Oct 26, 2025
2454017
Add exception for Classic theme
plum-pan Oct 26, 2025
615453a
exceptions - fix E302
MatteoCampinoti94 Oct 29, 2025
61a3f66
parse:check_page_raise - fix "classic" theme check when body tag does…
MatteoCampinoti94 Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions faapi/exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,5 +52,11 @@ class NoticeMessage(ParsingError):
"""


class ClassicTheme(ParsingError):
"""
The cookies supplied are for an account using the Classic theme. Please change your theme to Modern to use FAAPI.
"""


def _raise_exception(err: BaseException):
raise err
3 changes: 3 additions & 0 deletions faapi/parse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
from .exceptions import NoTitle
from .exceptions import ParsingError
from .exceptions import ServerError
from .exceptions import ClassicTheme

relative_url: Pattern = re_compile(r"^(?:https?://(?:www\.)?furaffinity\.net)?(.*)")
mentions_regexp: Pattern = re_compile(r"^(?:(?:https?://)?(?:www\.)?furaffinity\.net)?/user/([^/#]+).*$")
Expand All @@ -51,6 +52,8 @@ def parse_page(text: str) -> BeautifulSoup:
def check_page_raise(page: BeautifulSoup) -> None:
if page is None:
raise NonePage
elif page.body and "classic" in page.body.attrs.get("data-static-path", ""):
raise ClassicTheme
elif not (title := page.title.text.lower() if page.title else ""):
raise NoTitle
elif title.startswith("account disabled"):
Expand Down
Loading