Skip to content

1397 alarms are not ringing #1398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Futsch1 merged 2 commits into from
May 9, 2026
+27 −32
Merged

1397 alarms are not ringing #1398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26b59c0
Re-introduced single threaded executor
Futsch1 May 9, 2026
5bb07cc
Bump version to v1.22.14
Futsch1 May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ android {
minSdk = 28
multiDexEnabled = true
targetSdk = 36
versionCode = 168
versionName = "1.22.13"
versionCode = 169
versionName = "1.22.14"
base.archivesName = "MedTimer"
// Use this deprecated setting because Android Lint will not pick up androidResources.localeFilters correctly
@Suppress("DEPRECATION")
Expand Down
55 changes: 25 additions & 30 deletions app/src/main/java/com/futsch1/medtimer/alarm/ReminderAlarmActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,24 +15,25 @@ import androidx.appcompat.app.AppCompatActivity
import androidx.core.view.WindowCompat
import androidx.core.view.WindowInsetsCompat
import androidx.lifecycle.lifecycleScope
import com.futsch1.medtimer.LogTags
import com.futsch1.medtimer.R
import com.futsch1.medtimer.di.Dispatcher
import com.futsch1.medtimer.di.MedTimerDispatchers
import com.futsch1.medtimer.preferences.PreferencesDataSource
import com.futsch1.medtimer.reminders.notificationData.ReminderNotificationData
import dagger.hilt.android.AndroidEntryPoint
import kotlinx.coroutines.CoroutineDispatcher
import kotlinx.coroutines.Job
import kotlinx.coroutines.asCoroutineDispatcher
import kotlinx.coroutines.launch
import java.util.concurrent.ExecutorService
import java.util.concurrent.Executors
import java.util.concurrent.TimeUnit
import javax.inject.Inject


@AndroidEntryPoint
class ReminderAlarmActivity : AppCompatActivity() {

@Inject
@Dispatcher(MedTimerDispatchers.Default)
lateinit var backgroundDispatcher: CoroutineDispatcher
// Single-threaded executor ensures buildMediaPlayer, startAlarm, and pauseAlarm
// run sequentially, preventing concurrent MediaPlayer state transitions.
private val alarmExecutor = Executors.newSingleThreadExecutor().asCoroutineDispatcher()

@Inject
lateinit var preferencesDataSource: PreferencesDataSource
Expand All @@ -44,7 +45,6 @@ class ReminderAlarmActivity : AppCompatActivity() {
lateinit var audioManager: AudioManager

private var mediaPlayer: MediaPlayer? = null
private var buildMediaPlayerJob: Job? = null

override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
Expand All @@ -60,34 +60,30 @@ class ReminderAlarmActivity : AppCompatActivity() {

addAlarmFragment(intent)

buildMediaPlayerJob = lifecycleScope.launch(backgroundDispatcher) {
lifecycleScope.launch(alarmExecutor) {
buildMediaPlayer()
}
}

override fun onResume() {
super.onResume()
lifecycleScope.launch(backgroundDispatcher) {
lifecycleScope.launch(alarmExecutor) {
startAlarm()
}
}

override fun onPause() {
super.onPause()
lifecycleScope.launch(backgroundDispatcher) {
lifecycleScope.launch(alarmExecutor) {
pauseAlarm()
}
}

override fun onDestroy() {
super.onDestroy()
(alarmExecutor.executor as ExecutorService).awaitTermination(1, TimeUnit.SECONDS)
releaseMediaPlayer()
Log.d("ReminderAlarm", "Destroyed alarm activity")
}

private suspend fun awaitMediaPlayer(): MediaPlayer? {
buildMediaPlayerJob?.join()
return mediaPlayer
Log.d(LogTags.ALARM, "Destroyed alarm activity")
}

private fun buildMediaPlayer() {
Expand All @@ -112,11 +108,13 @@ class ReminderAlarmActivity : AppCompatActivity() {
if (tmpMediaPlayer != null) {
tmpMediaPlayer.isLooping = true
mediaPlayer = tmpMediaPlayer
} else {
Log.w(LogTags.ALARM, "Failed to create media player")
}
}

private suspend fun startAlarm() {
Log.d("ReminderAlarm", "Executing startAlarm job")
private fun startAlarm() {
Log.d(LogTags.ALARM, "Executing startAlarm job")

if (shallPlayAlarm()) {
playAlarmTone()
Expand All @@ -127,14 +125,12 @@ class ReminderAlarmActivity : AppCompatActivity() {
}
}

private suspend fun pauseAlarm() {
Log.d("ReminderAlarm", "Executing pauseAlarm job")

val mediaPlayer = awaitMediaPlayer() ?: return
private fun pauseAlarm() {
Log.d(LogTags.ALARM, "Executing pauseAlarm job")

try {
if (mediaPlayer.isPlaying) {
mediaPlayer.pause()
if (mediaPlayer?.isPlaying == true) {
mediaPlayer?.pause()
}
} catch (_: IllegalStateException) {
// Ignore
Expand All @@ -146,16 +142,15 @@ class ReminderAlarmActivity : AppCompatActivity() {
private fun releaseMediaPlayer() {
mediaPlayer?.release()
mediaPlayer = null
Log.d("ReminderAlarm", "Released media player")
Log.d(LogTags.ALARM, "Released media player")
}

private fun vibrate() {
vibrator.vibrate(VibrationEffect.createWaveform(longArrayOf(500, 500), 0))
}

private suspend fun playAlarmTone() {
val mediaPlayer = awaitMediaPlayer() ?: return
mediaPlayer.start()
private fun playAlarmTone() {
mediaPlayer?.start()
}

private fun shallPlayAlarm(): Boolean {
Expand All @@ -176,7 +171,7 @@ class ReminderAlarmActivity : AppCompatActivity() {

private fun addAlarmFragment(intent: Intent?) {
if (intent != null) {
Log.d("ReminderAlarm", "Adding alarm fragment")
Log.d(LogTags.ALARM, "Adding alarm fragment")
supportFragmentManager.beginTransaction()
.add(R.id.alarmFragmentContainer, AlarmFragment::class.java, intent.extras).commit()
}
Expand Down
Loading