Upgrade Arrow C++ to 20.0.0 #528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamreeve
force-pushed
the
arrow-20-upgrade
branch
from
a086587 to
0452dbc
Compare
3 tasks
marcin-krystianc
approved these changes
May 23, 2025
| .EnableWritePageIndex() | ||
| .DisableWritePageIndex() |
There was a problem hiding this comment.
Is this change necessary?
There was a problem hiding this comment.
This was flipping the order of operations so that the end state is different to the new default, to check that these methods have an effect.
| @@ -56,7 +56,7 @@ public static void TestPropertiesBuilder() | |||
| Assert.AreEqual(789, p.MaxRowGroupLength); | |||
| Assert.AreEqual(ParquetVersion.PARQUET_1_0, p.Version); | |||
| Assert.AreEqual(666, p.WriteBatchSize); | |||
| Assert.True(p.WritePageIndex); | |||
| Assert.False(p.WritePageIndex); | |||
There was a problem hiding this comment.
Is this change necessary?
| @@ -112,7 +112,7 @@ public static void TestOverrideDefaults() | |||
| DefaultWriterProperties.MaxRowGroupLength = 789; | |||
| DefaultWriterProperties.Version = ParquetVersion.PARQUET_1_0; | |||
| DefaultWriterProperties.WriteBatchSize = 666; | |||
| DefaultWriterProperties.WritePageIndex = true; | |||
| DefaultWriterProperties.WritePageIndex = false; | |||
There was a problem hiding this comment.
Is this change necessary?
There was a problem hiding this comment.
Same as above, this is changing the test to set the value to something different to the default, which changed from false to true.
| @@ -130,7 +130,7 @@ public static void TestOverrideDefaults() | |||
| Assert.AreEqual(789, p.MaxRowGroupLength); | |||
| Assert.AreEqual(ParquetVersion.PARQUET_1_0, p.Version); | |||
| Assert.AreEqual(666, p.WriteBatchSize); | |||
| Assert.True(p.WritePageIndex); | |||
| Assert.False(p.WritePageIndex); | |||
There was a problem hiding this comment.
Is this change necessary?
This was referenced Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #527