Fix issues with dependencies when using external Zookeeper#118
Open
danielskowronski wants to merge 2 commits intoG-Research:masterfrom
Open
Fix issues with dependencies when using external Zookeeper#118danielskowronski wants to merge 2 commits intoG-Research:masterfrom
danielskowronski wants to merge 2 commits intoG-Research:masterfrom
Conversation
dbcbe38 to
2120d3e
Compare
4 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #60
This chart depends on
bitnami/commonhelper chart forcommon.storage.class. It is indirectly pulled as dependency tobitnami/zookeeper. However, the latter one is only loaded when this chart is set to install Zookeeper. Therefore, users wanting to use external one (viazookeeper.enabled=falsevalue) are excludingbitnami/commonhelper, makingcommon.storage.classinvalid.This PR adds explicit import for
bitnami/commonwith associated tarball to conform with build workflow. Moreover,zookeeperrepository URL has been updated as per bitnami/charts#10539Validation commands: