[FEATURE] make Consul.NET versioning independent of Consul versioning#586
[FEATURE] make Consul.NET versioning independent of Consul versioning#586MohamedM216 wants to merge 19 commits intoG-Research:masterfrom
Conversation
Directory.Build.props
Outdated
| <Project> | ||
| <PropertyGroup> | ||
| <VersionPrefix>1.7.14.12</VersionPrefix> | ||
| <VersionPrefix>2.0.0</VersionPrefix> |
There was a problem hiding this comment.
Just a random number greater than the latest version. @marcin-krystianc please let me know your thoughts.
There was a problem hiding this comment.
I think 1.8.0 would be better (because we are not making any API/ABI breaking change so bumping the major version is not necessary).
|
@marcin-krystianc I've updated the PR to address the requested changes |
marcin-krystianc
left a comment
marcin-krystianc
left a comment
There was a problem hiding this comment.
Hi, few more comments. I've somehow forgot to submit them yesterday.
| For example version `1.6.1.0` is going to be normalized to `1.6.1`. So to avoid problems, versions and tags with zero in the fourth part should be avoided and explicit three part version should be used instead. | ||
| **MAJOR.MINOR.PATCH** | ||
|
|
||
| The library version is independent from the version of Consul server. Consul's HTTP API is largely backward compatible, therefore different versions of Consul.NET may work with multiple Consul server versions. |
There was a problem hiding this comment.
I would add one more sentence with a historical context, e.g.:
"Historically, the project used four-component version numbers (e.g. 1.7.14.3) where the first three components matched a Consul server version. Starting with version 1.8.0, the project switched to standard three-component semantic versioning. Consul's HTTP API is largely backward compatible, therefore different versions of Consul.NET may work with multiple Consul server versions."
Directory.Build.props
Outdated
| <Project> | ||
| <PropertyGroup> | ||
| <VersionPrefix>1.7.14.12</VersionPrefix> | ||
| <VersionPrefix>2.0.0</VersionPrefix> |
There was a problem hiding this comment.
I think 1.8.0 would be better (because we are not making any API/ABI breaking change so bumping the major version is not necessary).
MohamedM216
force-pushed
the
independent-consulnet-versioning
branch
from
4bfa571 to
00348ed
Compare
MohamedM216
force-pushed
the
independent-consulnet-versioning
branch
from
2bf8087 to
f17f8e1
Compare
Co-authored-by: Marcin Krystianc <marcin.krystianc@gmail.com>
README.md
Outdated
| [](https://twitter.com/oss_gr) | ||
|
|
||
| [](https://github.com/hashicorp/consul/tree/v1.7.14/api) | ||
|  |
There was a problem hiding this comment.
I think that this badge does not add any value now, it is just a noise. I would remove it.
Co-authored-by: Marcin Krystianc <marcin.krystianc@gmail.com>
Co-authored-by: Marcin Krystianc <marcin.krystianc@gmail.com>
Co-authored-by: Marcin Krystianc <marcin.krystianc@gmail.com>
Removed the Consul API badge from the README.
Co-authored-by: Marcin Krystianc <marcin.krystianc@gmail.com>
3 participants
Description
make Consul.NET versioning independent of Consul versioning
Related Issues
#541
Additional Context
Checklist
Please make sure to check the following before submitting your pull request: