FEATURE: Implement Agent Update ACL Tokens Endpoint#596
FEATURE: Implement Agent Update ACL Tokens Endpoint#596marietta-a wants to merge 9 commits intoG-Research:masterfrom
Conversation
marietta-a
changed the title
Consul.Test/AgentTest.cs
Outdated
| [SkippableFact] | ||
| public async Task Agent_UpdateToken() | ||
| { | ||
| var cutOffVersion = SemanticVersion.Parse("1.4.0"); |
There was a problem hiding this comment.
I think it should be 1.14.0?
There was a problem hiding this comment.
uhhh... from the logs, 1.15.0 perhaps?
marcin-krystianc
left a comment
marcin-krystianc
left a comment
There was a problem hiding this comment.
thanks for raising the PR. Generally it looks good, I would just want to improve the test. We can use [SkippableTheory] to parameterize the test. You can have a list of pairs (token_type , expected_result), so you can test positive and negative examples.
| Consul.Agent | ||
| Consul.Agent.LogStream | ||
| Consul.Agent.LogStream.Dispose() -> void | ||
| Consul.Agent.UpdateToken(Consul.AgentToken token, string target) -> System.Threading.Tasks.Task<Consul.WriteResult> |
There was a problem hiding this comment.
I think it is called token_type in consul (https://developer.hashicorp.com/consul/commands/acl/set-agent-token#usage)
| Consul.Agent.UpdateToken(Consul.AgentToken token, string target) -> System.Threading.Tasks.Task<Consul.WriteResult> | |
| Consul.Agent.UpdateToken(Consul.AgentToken token, string token_type) -> System.Threading.Tasks.Task<Consul.WriteResult> |
There was a problem hiding this comment.
Thanks for the suggestions @marcin-krystianc, I have updated the test to use [SkippableTheory]
marcin-krystianc
left a comment
marcin-krystianc
left a comment
There was a problem hiding this comment.
Perfect, thank you!
2 participants
Description
Related Issues
Addresses Issue: #480
Additional Context
Checklist
Please make sure to check the following before submitting your pull request: