[FEATURE] update ACL Token Read endpoint to add expnded parameter#601
Open
MohamedM216 wants to merge 2 commits intoG-Research:masterfrom
Open
[FEATURE] update ACL Token Read endpoint to add expnded parameter#601MohamedM216 wants to merge 2 commits intoG-Research:masterfrom
Read endpoint to add expnded parameter#601MohamedM216 wants to merge 2 commits intoG-Research:masterfrom
Conversation
3 tasks
Contributor
marcin-krystianc
left a comment
marcin-krystianc
left a comment
There was a problem hiding this comment.
HI @MohamedM216,
look at the example of a response when the expanded=true (https://developer.hashicorp.com/consul/api-docs/acl/tokens#sample-response-1). See, there are two new fields, ExpandedPolicies and ExpandedRoles.
The test should assert that these fields are filled in, when expanded=true and null when expanded=false.
MohamedM216
force-pushed
the
acl-token-read
branch
from
be4536f to
f6bda2c
Compare
Contributor
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
update ACL Token Read endpoint to add expnded parameter
Related Issues
#531
Additional Context
Checklist
Please make sure to check the following before submitting your pull request: