Issue 33 app force update#40
Open
sanasz91mdev wants to merge 8 commits intolocal-masterfrom
Open
Conversation
…y_app into issue-33-app-force-update
aubykhan
suggested changes
Feb 23, 2020
aubykhan
left a comment
aubykhan
left a comment
There was a problem hiding this comment.
@sanasz9109 Looks okay overall, just make these few changes.
| try { | ||
| var hostPlatform = Platform.isAndroid ? "android" : "ios"; | ||
| var forceVersion = await getApplicationConfiguration( | ||
| hostPlatform + '_force_update_version'); |
There was a problem hiding this comment.
Instead of doing this key creation here, I'd suggest to move it to remote config helper file and just pass the hostPlatform value to the new helper function.
Author
There was a problem hiding this comment.
but that will make the function quite specific right? .. i thought of creating a function that will intake any key and will out the value against it ..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.