fixed the paginition in student records #32
Open
Sampurnasit wants to merge 1 commit intoGDSC-RCCIIT:mainfrom
Open
fixed the paginition in student records #32Sampurnasit wants to merge 1 commit intoGDSC-RCCIIT:mainfrom
Sampurnasit wants to merge 1 commit intoGDSC-RCCIIT:mainfrom
Conversation
…ay records of 11 students
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Pagination behaved incorrectly when the student count was exactly 11.
totalPageshad a hardcoded edge-case that subtracted 1 wheneverfiltered.length === 11, causing one page to be lost.Fix
Removed the hardcoded special case.
totalPagesis now always computedcorrectly via
Math.ceil(filtered.length / pageSize).Result
With 11 students and pageSize 5, pagination now correctly shows 3 pages.
Fixes #23