Add markdown lint github action and Apply lint#93
Add markdown lint github action and Apply lint#93st-Wook wants to merge 51 commits intoGDevelopApp:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
It's just my trough:
|
|
It seems the Lint checker only verifies the indent for Unordered Lists. The indent for Ordered Lists should also be two, right? |
I would say 0: I don't want to add 2 spaces at the beginning of each bullet point for a single-level list. Why are you in favor of 2 spaces @Bouh ?
I would say yes. Regarding those formatting rules, I'm afraid it will prevent users to suggest documentation changes. Let me explain:
Considering those 3 points, I'm afraid 85% of the users opening a PR in the repo will have a failing CI and get discouraged by it and end up closed. Or this check could be converted in a "Fix action" that adds a commit with the fixes? |
I have made the modifications as you suggested! However, the GitHub action is failing due to permission issues. I have conducted the tests on my local repo PR! (local pr link) |
|
Edit: I think "pull_request_target" would have solved the permission issue. |
This reverts commit 964823b.
|
Creating commits to automatically fix the Lint seems challenging due to various issues... I'll open a new PR when a solution is found! |
Could you share your thoughts on adding a Markdown lint Github action to more easily find formatting errors in Markdown-formatted documents, especially things like nested lists? If you think it's a good idea, please decide on the following format rules (and let me know if you have any additional thoughts.):
I would also like to ask for our opinion on converting to Markdown lint rules when generating extended description documents!
lint Rules