Skip to content

Update common.inc with proposed "Show password" option #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
robertzago wants to merge 1 commit into
base: master
Choose a base branch
from
+20 −0
Draft

Update common.inc with proposed "Show password" option #333

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions devices/ms/Files/common.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1497,9 +1497,29 @@ Function GetPasswordBasedCredentials
${NSD_CreateLabel} 10 66u 60u 22u "<?php WindowsCommon::echoNsis(_("Repeat password:"))?>"
${NSD_CreatePassword} 67u 65u 80u 12u "$PASS2"
Pop $PASS2_F

; Adapted from https://nsis.sourceforge.io/NsDialogs_FAQ#How_to_hide.2Fshow_passwords_in_a_Text_Password_control

${NSD_CreateCheckbox} 10 69u 60u 22u "Show password"
Pop $hwnd
${NSD_OnClick} $hwnd ShowPassword

nsDialogs::Show
FunctionEnd

; Show the password
Function ShowPassword
Pop $hwnd
${NSD_GetState} $hwnd $0
ShowWindow $PASS1 ${SW_HIDE}
${If} $0 == 1
SendMessage $PASS1 ${EM_SETPASSWORDCHAR} 0 0
${Else}
SendMessage $PASS1 ${EM_SETPASSWORDCHAR} 42 0
${EndIf}
ShowWindow $PASS1 ${SW_SHOW}
FunctionEnd

; Handle user input
Function SavePasswordBasedCredentials
${NSD_GetText} $UNAME_F $UNAME
Expand Down