Open
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3174 +/- ##
========================================
Coverage 55.75% 55.75%
========================================
Files 1041 1041
Lines 88534 88534
========================================
Hits 49358 49358
Misses 39176 39176 ☔ View full report in Codecov by Sentry. |
CusiniM
reviewed
Jun 18, 2024
|
|
||
| def run_problem(): | ||
| """ | ||
| Run the GEOSX problem |
Collaborator
There was a problem hiding this comment.
Suggested change
| Run the GEOSX problem | |
| Run the GEOS problem |
CusiniM
reviewed
Jun 18, 2024
| from mpi4py import MPI | ||
| import pygeosx | ||
| from pygeosx_tools import wrapper | ||
| from geosx_xml_tools.main import preprocess_parallel |
Collaborator
There was a problem hiding this comment.
do you need this? It does not seem to be used.
Contributor
Author
There was a problem hiding this comment.
No, I missed cleaning up the import list when I removed the pre-processor from this example
CusiniM
reviewed
Jun 18, 2024
src/CMakeLists.txt
Outdated
| # message(WARNING "Temporarily changing the geosPythonBranch to cusini/fix-streak-cert-fail") | ||
| # set(GEOS_PYTHON_PACKAGES_BRANCH "cusini/fix-streak-cert-fail" CACHE STRING "" FORCE) | ||
| message(WARNING "Temporarily changing the geosPythonBranch to feature/sherman/addPygeosxIntegratedTests") | ||
| set(GEOS_PYTHON_PACKAGES_BRANCH "cusini/fix-streak-cert-fail" CACHE STRING "" FORCE) |
Collaborator
There was a problem hiding this comment.
you probably want to change this:
Suggested change
| set(GEOS_PYTHON_PACKAGES_BRANCH "cusini/fix-streak-cert-fail" CACHE STRING "" FORCE) | |
| set(GEOS_PYTHON_PACKAGES_BRANCH "feature/sherman/addPygeosxIntegratedTests" CACHE STRING "" FORCE) |
cssherman
force-pushed
the
feature/sherman/addPygeosTests
branch
from
715dac1 to
3f901c9
Compare
rrsettgast
requested review from
castelletto1,
jhuang2601,
paveltomin and
rrsettgast
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
geosPythonPackages PR: GEOS-DEV/geosPythonPackages#22