feat: Add viscosity thermal expansion coefficient to ThermalCompressibleSinglePhaseFluid#3951
Open
behzaadh wants to merge 1 commit intoGEOS-DEV:developfrom
Open
feat: Add viscosity thermal expansion coefficient to ThermalCompressibleSinglePhaseFluid#3951behzaadh wants to merge 1 commit intoGEOS-DEV:developfrom
behzaadh wants to merge 1 commit intoGEOS-DEV:developfrom
Conversation
Contributor
@behzaadh This looks good. We need to update the documentation and add your 1D test case. I'm afraid I am not able to push to your fork. I will send you a diff of what I am thinking. |
Collaborator
…bleSinglePhaseFluid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Viscosity thermal expansion coefficient was needed in order to get a good match between Intersect and GEOS