Skip to content

fix: Fix bug in L2 norm calculation for isothermal #3954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dkachuma wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: Fix bug in L2 norm calculation for isothermal #3954

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/coreComponents/physicsSolvers/fluidFlow/CompositionalMultiphaseFVM.cpp
View file
Open in desktop
Copy link
Contributor

@tjb-ltk tjb-ltk Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should defaults in well also be set ?

Copy link
Contributor Author

@dkachuma dkachuma Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well looks to be handled differently. There's no volume balance and it seems it's all sized correctly (1 for isothermal and 2 for thermal). CompositionalMultiphaseWell.cpp:1379-1388

Original file line number Diff line number Diff line change
Expand Up @@ -538,6 +538,8 @@ real64 CompositionalMultiphaseFVM::calculateResidualNorm( real64 const & GEOS_UN
// volume
subRegionResidualNorm[1] = subRegionFlowResidualNorm[1];
subRegionResidualNormalizer[1] = subRegionFlowResidualNormalizer[1];
// Ensure that the normalizer for the energy equation is non-zero
subRegionResidualNormalizer[2] = m_nonlinearSolverParameters.m_minNormalizer;
}

// step 2: first reduction across meshBodies/regions/subRegions
Expand Down
Loading