Change for compiling GEOSX with Trilinos/Tpetra interface#20
Open
Change for compiling GEOSX with Trilinos/Tpetra interface#20
Conversation
rrsettgast
approved these changes
Aug 10, 2020
…ing Tpetra headers included in PTP via SurfaceGenerator. This change should be reverted if PTP is moved into main code.
4417a17 to
f67d3e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR works around the following problem:
ParallelTopologyChange.hppincludesSurfaceGenerator.hpp. When GEOSX is compiled withTrilinosTpetraas selected LAI, it therefore transitively includesTpetraVectorandTpetraMatrix, which include forward declaration headers from Tpetra. However, because PTP does not have eitherlinearAlgebraorphysicsSolversas its dependency, BLT/Cmake does not place Trilinos install dir on its include paths, and the compiler fails to find those Tpetra headers. I simply addedlinearAlgebraas a dependency for now (addingphysicsSolverswould create a circular dependency).Couple notes:
EpetraVectororEpetraMatrix, instead simply forward declaring the types ourselves. This is significantly more difficult to do with Tpetra, because the types are templates with a bunch of default parameters that are defined deep in Tpetra headers at config time. It would be unwise for us to try replicate all those namespaces/types. Luckily, Tpetra provides forward declaration headers for every public type (e.g.Tpetra_Vector_fwd.hpp), and we have to include those.linearAlgebra. Root of the issue is that it includesSurfaceGenerator.hpponly for the definition ofModifiedObjectLists. A better solution would be to putModifiedObjectListsin its own header and forward declare it in both of the above. Or at least move definition toParallelTopologyChange.hpp. Let me know your preferences.Related to GEOS-DEV/GEOS#1086