feat: Add new meshes for the tests and implemente the missing one for the post-processing filter #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomainBaville
changed the title
Collaborator
paloma-martinez
left a comment
paloma-martinez
left a comment
There was a problem hiding this comment.
Looks good for me, just a few suggestions
| @@ -0,0 +1,6 @@ | |||
| Those meshes used for testing post-processing filters came from a GEOS simulation with the version of the 27th November 2025. | |||
Collaborator
There was a problem hiding this comment.
Commit number would be more relevant than day.
| Those meshes used for testing post-processing filters came from a GEOS simulation with the version of the 27th November 2025. | ||
| The XML-files used to launch the simulation came from the integrated tests of GEOS: singlePhasePoromechanics_FaultModel_well_seq_smoke.xml located [here](https://github.com/GEOS-DEV/GEOS/tree/develop/inputFiles/poromechanicsFractures) | ||
|
|
||
| The ParaView plugin "PVGeosBlockExtractAndMerge" has been use to get the vtm with the block "CellElementRegion"from the simulation pvd result. The integrated ParaView plugin "merge block" has been use to get a vtu with the data of the second time step. |
Collaborator
There was a problem hiding this comment.
Suggested change
| The ParaView plugin "PVGeosBlockExtractAndMerge" has been use to get the vtm with the block "CellElementRegion"from the simulation pvd result. The integrated ParaView plugin "merge block" has been use to get a vtu with the data of the second time step. | |
| The ParaView plugin "PVGeosBlockExtractAndMerge" has been used to get the vtm with the block "CellElementRegion" from the simulation pvd result. The integrated ParaView plugin "merge block" has been used to get a vtu with the data of the second time step. |
paloma-martinez
approved these changes
Feb 3, 2026
paloma-martinez
deleted the
RomainBaville/feat/AddTheMissingTestForThePostProcessingFilter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to harmonize the post-processing filter tests:
This PR close #215