v5: Remove custom CTest pre-test build configuration#515
Merged
Conversation
mathomp4
added
the
0 diff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request simplifies the test configuration by removing a custom CTest pre-test build step.
Previously, running
ctestwould automatically (re-)build the tests. But,ctestis not a builder, it's a tester. The right thing to do if you need to rebuild because you edited the test, is use cmake/make/ninja. For example withMAPL.generic.testssay, with this update running:will not rebuild the tests if you change something. You'd need to positively run:
or:
or most generic:
(assuming you are in your build directory). Use full path to build-dir if not.