Skip to content

all-sky ATMS radiance assimilation and using surface-sensitive ATMS radiances #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
gmao-yzhu wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

all-sky ATMS radiance assimilation and using surface-sensitive ATMS radiances #207

gmao-yzhu wants to merge 2 commits into from

Conversation

@gmao-yzhu
Copy link
Contributor

@gmao-yzhu gmao-yzhu commented Jul 14, 2025 •
edited
Loading

This PR is to achieve the following purposes:

  1. Use a common beamwidth for all channels,
  2. Change ATMS radiance usage in GEOS from clear-sky approach to all-sky approach.
  3. Add the assimilation of surface-sensitive channels 1-4 and 16 in GEOS.
  4. Add cloud seed for rain and snow.
  5. Code changes on DA side for cloud fraction and overlap are also included (Wei, Jianjun, me have tested the impact on OmFs of CrIS, GMI, ATMS but not turned on yet).

@gmao-yzhu gmao-yzhu requested a review from a team as a code owner July 14, 2025 16:27
@github-actions
Copy link

github-actions bot commented Jul 14, 2025

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found:

@gmao-yzhu gmao-yzhu added enhancement New feature or request Non 0-diff The changes in this pull request are non-zero-diff labels Jul 14, 2025
gmao-wgu
gmao-wgu previously approved these changes Jul 22, 2025
View reviewed changes
Copy link
Contributor

@gmao-wgu gmao-wgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good to me.

gmao-wgu
gmao-wgu approved these changes Feb 2, 2026
View reviewed changes
Copy link
Contributor

@gmao-wgu gmao-wgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me!

@mhan-mars
Copy link
Contributor

mhan-mars commented Feb 2, 2026

I was wondering why channel 15 is still set to "-1" in gmao_global_satinfo.txt?

@gmao-wgu
Copy link
Contributor

gmao-wgu commented Feb 2, 2026

I was wondering why channel 15 is still set to "-1" in gmao_global_satinfo.txt?
It does not matter. Whether it is active or passive is determined by the resource file active_channels.tbl.

mhan-mars
mhan-mars approved these changes Feb 2, 2026
View reviewed changes
Copy link
Contributor

@mhan-mars mhan-mars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmao-wgu gmao-wgu gmao-wgu approved these changes

@mhan-mars mhan-mars mhan-mars approved these changes

@rtodling rtodling Awaiting requested review from rtodling

@mjkagnes123 mjkagnes123 Awaiting requested review from mjkagnes123

@ahrem1234 ahrem1234 Awaiting requested review from ahrem1234

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

enhancement New feature or request Non 0-diff The changes in this pull request are non-zero-diff

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gmao-yzhu @mhan-mars @gmao-wgu