Conversation
|
Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: |
|
Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: enhancement |
gmao-yzhu
added
the
Non 0-diff
There was a problem hiding this comment.
It looks like the 'hamd' variable isn't being used besides being set to -1. Should it still be in the file?
jemccurr
left a comment
jemccurr
left a comment
There was a problem hiding this comment.
I went through the changes and everything looks good. Just had one comment on read_satwind.f90 for the hamd variable.
|
I am trying these changes on my corner of the world before fully placing them in develop - they look good, but I just want one cycle w/ them. |
|
Also notice the need to add explanation of change in CHANGELOG.md ... I did that already and committed change here. |
|
Thanks Wei, Josh and Ricardo. |
|
BTW: I believe I need to get a corresponding PR w/ changes to the ensemble observer settings. I can make those changes if okay by you Yanqiu. Let me know. |
|
Yes, I forgot to change qc_satwind setting in obs1gsi_mean.rc and obs1gsi_member.rc. Please go ahead to change them. |
3 participants
The QC changes to satwinds made by E. Lee were submitted several years ago (Updated AMV QC and thinning grids #81). As GEOS ADAS has evolved significantly since the PR#81 was submitted, recently these changes have been re-tested with the latest GEOS.
Except for the change with height assignment, the following original QC changes are re-tested and included in this PR:
turn on the logical variable qc_satwnds but comment out the part that removes IR winds in the middle layer,
remove IR, VIS winds at low level over lands,
remove MSG IR winds over land for lat > 5N,
change thinning grid sizes for some satwinds in gmao_global_convinfo.txt.