Add extra ABI output and change water vapor unit #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhan-mars
added
enhancement
gmao-wgu
previously approved these changes
Feb 3, 2026
rtodling
approved these changes
Feb 11, 2026
| do iabsorb = 1, n_absorbers | ||
| write (fieldname, "(A,I0.2)") "atmosphere_absorber_", atmosphere(1)%absorber_id(iabsorb) | ||
| call nc_diag_data2d(trim(fieldname), sngl(atmosphere(1)%absorber(:,iabsorb))) ! check %absorber_units | ||
| if (iabsorb == 1) then |
Contributor
There was a problem hiding this comment.
Why do you need this scaling or not scaling option? Is something wrong w/ the way the code scales the quantity of interest here?
I'll also add that this change is bit dangerous since it implies the order of aborbers is what you think it is ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ABI standard deviation to netcdf output file and change water vapor unit from g/kg to kg/kg for JEDI UFO tests.