re-order elements and vertices

[weiyuan-jiang]

Types of change(s)

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Trivial change (affects only documentation or cleanup)
• Refactor (no functional changes, no api changes)

Checklist

• Tested this change with a run of GEOSgcm
• Ran the Unit Tests (make tests)

Description

for discussion

Related Issue

[github-actions]

This PR is being prevented from merging because you have added one of our blocking labels: 🚫 Contingent - DNA. You'll need to remove it before this PR can be merged.

[github-actions]

This PR is being prevented from merging because you have not added one of our required labels: 0 diff, 0 diff trivial, 😲 Non 0 Diff, 🔧 Github Actions. Please add one so that the PR can be merged.

[github-actions]

This PR is being prevented from merging because you have not added one of our required labels: 0 diff, 0 diff trivial, 😲 Non 0 Diff, 🔧 Github Actions. Please add one so that the PR can be merged.

[mathomp4]

Huh. Lots of CI failures. ninja seems unhappy with:

ninja: build stopped: multiple rules generate mesh2/sf_direction.mod.

As for ifx, not sure. Seems like our spurious random failure.

Also from GNU:

Error copying Fortran module "mesh2/sf_direction.mod".  Tried "mesh2/SF_DIRECTION.mod" and "mesh2/sf_direction.mod".
make[2]: *** [mesh2/CMakeFiles/to_mesh2.x.dir/depend.make:7: mesh2/CMakeFiles/to_mesh2.x.dir/sf_direction.mod.stamp] Error 1
make[1]: *** [CMakeFiles/Makefile2:9260: mesh2/CMakeFiles/to_mesh2.x.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 89%] Building Fortran object mesh2/CMakeFiles/xgrid.x.dir/Direction.F90.o
Error copying Fortran module "mesh2/sf_direction.mod".  Tried "mesh2/SF_DIRECTION.mod" and "mesh2/sf_direction.mod".
make[2]: *** [mesh2/CMakeFiles/xgrid2.x.dir/depend.make:7: mesh2/CMakeFiles/xgrid2.x.dir/sf_direction.mod.stamp] Error 1
make[1]: *** [CMakeFiles/Makefile2:9356: mesh2/CMakeFiles/xgrid2.x.dir/all] Error 2

[weiyuan-jiang]

There are a few make_esmf_mesh subroutines. My tests show only the one works. @tclune, We should clean those up

[tclune]

There are a few make_esmf_mesh subroutines. My tests show only the one works. @tclune, We should clean those up

Please do. The extra copies were all just attempts to work around an unknown issue.

[weiyuan-jiang]

Notes:
With the latest update, time mpirun -np 6 ./xgrid2.x
multi_connections: 49 s
ordered multi_connections: 38 s

tri_conn : 83 S
ordered tri_conn 75 s

quad_conn gets error when creating handler from xgrid to latlon grid:

pe=00002 FAIL at line=00085 xgrid2.F90 <status=513>

[mathomp4]

Notes: With the latest update, time mpirun -np 6 ./xgrid2.x multi_connections: 49 s ordered multi_connections: 38 s

tri_conn : 83 S ordered tri_conn 75 s

quad_conn gets error when creating handler from xgrid to latlon grid:

pe=00002 FAIL at line=00085 xgrid2.F90 <status=513>

@weiyuan-jiang Just for my own benefit, are these good? Bad? That is, should "ordered tri_conn" be the best? quad_conn?

[weiyuan-jiang]

Notes: With the latest update, time mpirun -np 6 ./xgrid2.x multi_connections: 49 s ordered multi_connections: 38 s
tri_conn : 83 S ordered tri_conn 75 s
quad_conn gets error when creating handler from xgrid to latlon grid:
pe=00002 FAIL at line=00085 xgrid2.F90 <status=513>

@weiyuan-jiang Just for my own benefit, are these good? Bad? That is, should "ordered tri_conn" be the best? quad_conn?

After Bob made the change, the tri and quad are not necessary any more. Every thing will be the original version except we order the elements and vertices.

[weiyuan-jiang]

For the record, here is the summary of xgrid.F90 print out ( mesh min resolution C1440, destination C720)

	random (s) 96 pe	Ordered (s) 96 pe	ordered 216 pe	ordered 864 pe
Creating xgrid (mesh, agrid)	6.3	4.7	2.15	0.59
Creating handle(Mesh 2 xgrid	6.0	2.1	1.4	1.14
Mesh 2 xgrid( regrid)	0.001	0.008	0.0006	0.0006
Creating handle(xgrid 2 agrid)	6.6	2.4	1.67	0.78
xgrid 2 mesh(regrid)	0.002	0.0009	0.0005	0.00016
Creating Handle(mesh 2 agrid)	7.3	3.67	1.97	1.4
Mesh 2 agrid(regrid)	0.002	0.0016	0.0007	0.002

[tclune]

@weiyuan-jiang Please use triple back-ticks and spacing to make the table readable here.

[mathomp4]

@weiyuan-jiang Please use triple back-ticks and spacing to make the table readable here.

I converted it into a Github Markdown Table. I forget those are available!

[weiyuan-jiang]

@weiyuan-jiang Please use triple back-ticks and spacing to make the table readable here.

I converted it into a Github Markdown Table. I forget those are available!

That is nicer !

[weiyuan-jiang]

Test for mesh minresolution c2880, destination c1440)

	random (s) 96 pe	Ordered (s) 96 pe	ordered 216 pe	ordered 864 pe
Creating xgrid (mesh, agrid)	31.3	22.5	10.	2.7
Creating handle(Mesh 2 xgrid)	34.4	10.7	7.7	7.0
Mesh 2 xgrid(regrid)	0.006	0.0037	0.0015	0.0008
Creating handle(xgrid 2 agrid)	11.6	11.6	8.6	7.3
xgrid 2 mesh(regrid)	0.0037	0.0037	0.0018	0.0006
Creating Handle(mesh 2 agrid)	44.0	19.1	11.2	7.6
Mesh 2 agrid(regrid)	0.004	0.0024	0.0014	0.002