Feature/aspect unit tests #4329
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…date_from_payload - Tests for update_from_payload with ESMF_Field (R4, R8, I4, I8, MIRROR) - Tests for update_from_payload with ESMF_FieldBundle (R4, R8, MIRROR) - Tests for update_payload with ESMF_Field (R4, R8, I4, I8, MIRROR) - Tests for update_payload with ESMF_FieldBundle (R4, R8, MIRROR) - Round-trip tests to verify data integrity - Corner cases: no field/bundle provided, multiple consecutive updates - Tests for overwriting existing typekind values - Tests for proper mirror flag handling These tests ensure reliable operation of critical framework methods that synchronize TypekindAspect state with ESMF payloads.
- Add comprehensive test suite for TypekindAspect (19 tests) - Test update_payload() and update_from_payload() methods - Cover R4, R8, I4, I8, and MIRROR typekinds for Field and FieldBundle - Initialize with non-matching typekinds to avoid false positives - Refactor FieldBundleInfo to delegate typekind handling to FieldInfo - Removes duplicate to_string/to_TypeKind functions - Fixes MIRROR typekind support for bundles (was returning 200 instead of "<MIRROR>") - FieldInfoGetInternal/SetInternal now handle typekind parameter
tclune
added
🪲 Bugfix
atrayano
approved these changes
Jan 22, 2026
Contributor
atrayano
left a comment
atrayano
left a comment
There was a problem hiding this comment.
This a general comment: most of the new PF unit tests call ESMF_FieldBundleDestoy. Since ESMF does not destroy any of the fields inside the bundle, this potentially would be causing a memory leak. IIn unit tests, this is mostly irrelevant, but it will be good to not "show" a bad coding practice to the rest of the users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of change(s)
Checklist
make tests)Description
Related Issue