Skip to content

Conversation

@weiyuan-jiang
Copy link
Contributor

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

This PR adds support to ESMF_Mesh

Related Issue

@github-actions
Copy link

github-actions bot commented Feb 4, 2026

This PR is being prevented from merging because you have not added one of our required labels: 0 diff, 0 diff trivial, 😲 Non 0 Diff, 🔧 Github Actions. Please add one so that the PR can be merged.

@weiyuan-jiang
Copy link
Contributor Author

weiyuan-jiang commented Feb 4, 2026

Issues:

1. There are two coordinates in ESMF_Mesh, nodeCoords and centerCoords.  In the MeshGeomSpec, should we provide two set_coordinates and get_coordinates?

2. According to Netcdf coordinate conventions:  
   A) 1D variable has the same name as its dimension ;
   B) Variables containing coordinate data that do not share the exact name of their dimension should have coordinates attribute.
   
In MAPL FileMetadata,  above A) is used as a criteria for coordinate variables. It may have to add subroutines to address B).  For a file containing ESMF_Mesh, I am wondering to add coordinate attributes to the Coord variables.

@tclune
Copy link
Collaborator

tclune commented Feb 4, 2026

I'm still not seeing anything wrong with what MAPL is doing . I need a concrete header and what goes wrong when MAPL tries to read/write that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants