add the options to create locstream with local_id #4395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiyuan-jiang
added
0 Diff Trivial
tclune
reviewed
Feb 12, 2026
| !A special subroutine for Nx1 Grid in river-routing grid comp | ||
| !Some information in the locstream is not filled | ||
| subroutine MAPL_LocstreamCreateSimple(Locstream, grid, rc) | ||
| subroutine MAPL_LocstreamCreateSimple(Locstream, grid, local_id, rc) |
Collaborator
There was a problem hiding this comment.
Can you provide a use case where "local_id" would not be a contiguous list of integers?
I really don't think this option is needed.
Contributor
Author
There was a problem hiding this comment.
This option is used to output mesh just like a locstream. The order will be the elementIDs (local_id here). We don't have to assume the elementIDs are contiguous inside a PET and across the distribution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of change(s)
Checklist
make tests)Description
Add an option local_id to create locstream from a simple Nx1 grid
Related Issue