feat: implement subdecision annulment propagation logic#508
Draft
tomudding wants to merge 3 commits intoGEWIS:mainfrom
Draft
feat: implement subdecision annulment propagation logic#508tomudding wants to merge 3 commits intoGEWIS:mainfrom
tomudding wants to merge 3 commits intoGEWIS:mainfrom
Conversation
Member
Author
|
A draft, because there are some issues that I have not solved:
Ideally, we also fix GH-283 in this. |
323326a to
5affe37
Compare
Member
Author
|
Found the cause of issue 2: GH-227. However, that should be fixed by properly going backwards through the subdecisions. |
5affe37 to
7416f17
Compare
We have repeatedly encountered inconsistencies in ReportDB (which is the materialised view of GEWISDB) where remnants of annulled decisions remained visible. A common example was bodies that were founded during a board switch and later annulled but still appear in ReportDB because the body entity itself was never removed. In the past we have always solved this by converting the original decision (the one being annulled) to a textual decision, effectively preventing the body (or other entity) from being created. This commit introduces a robust annulment mechanism for decisions and their subdecisions. This new functionality explicitly reverts or removes each subdecision type, ensuring that annulments leave no residual state in ReportDB.
7416f17 to
86e660a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We have repeatedly encountered inconsistencies in ReportDB (which is the materialised view of GEWISDB) where remnants of annulled decisions remained visible. A common example was bodies that were founded during a board switch and later annulled but still appear in ReportDB because the body entity itself was
never removed.
In the past we have always solved this by converting the original decision (the one being annulled) to a textual decision, effectively preventing the body (or other entity) from being created.
This commit introduces a robust annulment mechanism for decisions and their subdecisions. This new functionality explicitly reverts or removes each subdecision type, ensuring that annulments leave no residual state in ReportDB.
Related issues/external references
Fixes ABC-2411-508.
Types of changes