First time & some other bugs #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Develop was updated, first_time started failing tests. Diagnose why!
- Save logfiles, even if it's a restart - save all logfiles while running multiple tests in run/data/ - more robust (no hardcoding log000002.dat)
- Logfiles are output with one decimal point now - get_potential uses iAlt=2, not iAlt=nAlts-1 - potenital & aurora are actually calculated at t=0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BUG/etc.] Bug fixes all over the place!
No issue was ever made for these things. But this PR fixes a number of bugs:
time since ...units (Jan 1 1965, not time since run began)DoSeparateHPIflag is correctly handledChanges to GITM outputs
Some. Test solutions are all updated. IE patterns will be shifted slightly, and restarts may look different. But they should be "more correct" now.