Refactor Linear Apollo Display glyph drawing#725
Open
garrettjstevens wants to merge 16 commits intomainfrom
Open
Refactor Linear Apollo Display glyph drawing#725garrettjstevens wants to merge 16 commits intomainfrom
garrettjstevens wants to merge 16 commits intomainfrom
Conversation
Contributor
|
As the draw method for the LASFD GeneGlyph is so bespoke, perhaps it's not an issue? Do you envisage that it could be broken by this refactor? |
Contributor
Author
garrettjstevens
force-pushed
the
refactor_glyph_draw_lad
branch
2 times, most recently
from
26ce92c to
37d2519
Compare
garrettjstevens
force-pushed
the
refactor_glyph_draw_lad
branch
from
37d2519 to
ebd14fe
Compare
skip-checks:true
garrettjstevens
force-pushed
the
refactor_glyph_draw_lad
branch
from
54df42e to
55a293a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another part (following #724) of refactoring the drawing code to be easier to maintain. This works on the Linear Apollo Display glyphs
draw()methods. Three new glyph were addeed: TranscriptGlyph, ExonGlyph, and CDSGlyph. Having the drawing code broken out into separate glyphs makes it a lot easier to track. It also allows the track to now draw transcripts that don't have a gene parent with the TranscriptGlyph, where before it used the GenericChildGlyph. It also fixes it so that the track doesn't draw out of bounds when displaying multiple regions.This only addresses drawing, selected/hovered feature highlighting, hovering, drag preview drawing, etc. is not addressed by this and most of those still don't work correctly when displaying muliple regions. It also doesn't address the Linear Apollo Six Frame Display.