Devel cleaning_cluster_population#152
Open
ChiaraLionello wants to merge 34 commits intoGMPavanLab:mainfrom
Open
Devel cleaning_cluster_population#152ChiaraLionello wants to merge 34 commits intoGMPavanLab:mainfrom
ChiaraLionello wants to merge 34 commits intoGMPavanLab:mainfrom
Conversation
SimoneMartino98
requested changes
Feb 10, 2026
Collaborator
SimoneMartino98
left a comment
SimoneMartino98
left a comment
There was a problem hiding this comment.
Basically, 90% of the review has already been done in #149 (which was closed due to a technical issue).
Here I’m reviewing only the newest changes. I have just two minor comments then everything looks good from my side.
Good job, @ChiaraLionello 👍
Suggestion from Simone Co-authored-by: Simone Martino <157410539+SimoneMartino98@users.noreply.github.com>
andrewtarzia
requested changes
Feb 10, 2026
Collaborator
andrewtarzia
left a comment
andrewtarzia
left a comment
There was a problem hiding this comment.
Looking good! A few things we need to clarify.
docs/source/_static/tutorials/cleaning_cluster_population/cluster_population.png
Show resolved
Hide resolved
…entals from advanced topics.
andrewtarzia
approved these changes
Feb 12, 2026
Collaborator
andrewtarzia
left a comment
andrewtarzia
left a comment
There was a problem hiding this comment.
Minor changes, looks great! Thank you @ChiaraLionello
docs/source/_static/tutorials/cleaning_cluster_population/cluster_population.png
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Development of a function that cleans small clusters and assigning them to a bigger cluster, plus writing its tutorial.