Skip to content

Feature/154 branchid#155

Merged
chrisdicaprio merged 2 commits intomainfrom
feature/154-branchid
Apr 9, 2026
Merged

Feature/154 branchid#155
chrisdicaprio merged 2 commits intomainfrom
feature/154-branchid

Conversation

@chrisdicaprio
Copy link
Copy Markdown
Collaborator

closes #154

This does not break toshi-hazard-store function build_rlz_source_map as that function falls back on using the branch identity which is a sorted list of source nrml IDs separated by "|". Judging by the comments, it is likely this is the expected OQ behavior for the THS function. https://github.com/GNS-Science/toshi-hazard-store/blob/a09a7206ae88e19d175b9ac76e33a3964bf3c2e5/toshi_hazard_store/oq_import/parse_oq_realizations.py#L97

@chrisdicaprio chrisdicaprio requested review from chrisbc and voj April 7, 2026 19:11
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.74%. Comparing base (1512963) to head (2913772).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
+ Coverage   87.63%   87.74%   +0.11%     
==========================================
  Files          35       35              
  Lines        1714     1714              
  Branches      218      218              
==========================================
+ Hits         1502     1504       +2     
+ Misses        169      167       -2     
  Partials       43       43              
Flag Coverage Δ
unittests 87.74% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@voj voj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisdicaprio chrisdicaprio merged commit 616cd73 into main Apr 9, 2026
11 checks passed
@chrisdicaprio chrisdicaprio deleted the feature/154-branchid branch April 9, 2026 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

use branch registry_identity as branch ID

3 participants