Merged
Conversation
…s labels Adds an optional yTickFormat prop to GroupCurveChartProps and GroupCurveChartResponsiveProps, allowing callers to supply a custom tick formatter (e.g. scientific notation via toExponential). Includes ScientificNotation Storybook stories for both GroupCurveChart and GroupCurveChartResponsive.
voj
approved these changes
Mar 31, 2026
Collaborator
voj
left a comment
voj
left a comment
There was a problem hiding this comment.
LGTM
This looks very familiar. Was the other fix for weka?
Collaborator
|
Should you increase the version number? |
Collaborator
Author
good catch, that's done now |
Collaborator
Author
Similar, but #170 had fixed the tick labels being printed with scientific unit characters ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #172
yTickFormatprop for scientific notation