Skip to content

fix: simplify loop detection logic in proof_handler #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blake-pro wants to merge 2 commits into
base: dev
Choose a base branch
from
+15 −3
Open

fix: simplify loop detection logic in proof_handler #360

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27b2db7
fix: simplify loop detection logic in proof_handler
blake-pro Jan 21, 2026
4cca716
fix: enhance loop detection logic
blake-pro Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions node/src/rpc_service/handler/proof_handler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,21 @@ use std::sync::Arc;

/// Checks if the request host matches the configured proof builder host to prevent forwarding loops.
fn is_loop_detected(host: &str, request_host: Option<&str>) -> bool {
if let Some(request_host) = request_host {
host == request_host
|| host.starts_with(&format!("{}:", request_host.split(':').next().unwrap_or("")))
if let Some(req_host) = request_host {
let mut clean_host = host;

// Remove scheme if present (e.g. "http://")
if let Some(rest) = clean_host.strip_prefix("http://") {
clean_host = rest;
} else if let Some(rest) = clean_host.strip_prefix("https://") {
clean_host = rest;
}

// Remove trailing slash
clean_host = clean_host.trim_end_matches('/');

// Case-insensitive comparison
clean_host.eq_ignore_ascii_case(req_host)
} else {
false
}
Expand Down
Loading