Skip to content

[WIP] primreact Knob component#3

Open
smoothdeveloper wants to merge 1 commit intoGPetrites:developfrom
smoothdeveloper:knob-component
Open

[WIP] primreact Knob component#3
smoothdeveloper wants to merge 1 commit intoGPetrites:developfrom
smoothdeveloper:knob-component

Conversation

@smoothdeveloper
Copy link
Copy Markdown

@smoothdeveloper smoothdeveloper commented Apr 1, 2024

@GPetrites, thanks for the project!

I intend to add the Knob component, here are the F# changes.

In my local working copy, I shuffled things a bit:

  • replacing the packaging setup (not familiar and was more issue for me to try locally with updated dependencies), using vite.config.mts
  • adding prop-types dependency
  • updating to recent fable packages

My local changes seems to work, both the samples page and the docs, but I'm not 100% confident my changes are the way you'd like to manage the repository moving forward.

Please let me know if you'd like to see those changes in this branch, or would prefer to nudge the branch yourself to better fit the environment you've setup, or if we should try another thing?

Thanks for reviewing and considering if adding this component can be done for future version of the library.

edit: I'm not done with the bindings, just setting up the thing. I'll keep the ball rolling with more coverage of the library and documentation, if this is suitable for future version of the library.

@smoothdeveloper smoothdeveloper changed the title the core minimal changes to add primreact Knob component [WIP] primreact Knob component Apr 1, 2024
@GPetrites
Copy link
Copy Markdown
Owner

I'm glad you find this package useful. At the time I published, I hoped that I would be an active user as well as offering to the community. Unfortunately my group isn't doing much web development and haven't used this.

Would you be interested in taking ownership so that you can continue to evolve?

@smoothdeveloper
Copy link
Copy Markdown
Author

@GPetrites thanks for the feedback!

I'm ok to attempt to evolve it a bit, for now I just needed a knob, but I see the library is actually useful and I like to contribute to the fable and react bindings ecosystem to learn more about it.

Let me push this PR a bit forward and figure if I can setup the website from scratch in my fork, just for practice, over coming weeks, and then I'll come back to see how we can proceed.

I think the easiest would be to keep the repository as is, and figure out which rights would help me prepare new official release of the nuget and website.

I'll also try to get in touch with people contributing to Feliz ecosystem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants