Conversation
mikeAdamss
left a comment
There was a problem hiding this comment.
sorry, having issues running these 😢
There was a problem hiding this comment.
Sorry for the super late review. I'm having issues running make test for plone.
Don't know what's going on but I get reams of errors, the theme seems to be python test packages can't be found or are not installed.
missing packages:
- No module named 'zc.zlibstorage'
- No module named 'hamcrest'
unsure if its just a python thing, but hamcrest is a package of handy assertion matchers (for use while writing tests...or in databaker oddly enough)
| @@ -35,7 +35,12 @@ export $(docker inspect --format='{{join .Config.Env " "}}' plone:${PLONE_VERSIO | |||
| # restore my path variable | |||
| export PATH=$mypath | |||
There was a problem hiding this comment.
not your doing, but I don't think this does anything if it ever did.
ignore that, yes it does
| @@ -7,6 +7,11 @@ all: build | |||
| build: | |||
| docker build --build-arg POSTGRES_PASSWORD=$(POSTGRES_PASSWORD) --tag plone . | |||
There was a problem hiding this comment.
not sure if its documented but this will only work if the env var POSTGRES_PASSWORD is set, its possible we want toset it, or maybe stick a conditional in to tell people off for not doing so
if [ -z "$POSTGRES_PASSWORD" ]; then
echo "POSTGRES_PASSWORD is not set"
exit
fi
something like that...maybe... my bash ain't that great tbh.
sudos added to pipenv commandsnoerrorflag added to CPPflagsLong term it would be preferable to move the testing behaviour into the Plone docker container to remove the need for local pipenv/python installs, but this is just to make what is there at the moment runnable.
NB: the tests don't all pass, but at least they are runnable and output their results which is the scope of this makefile