DLUHC _domestic_energy_performance_certificates_for_existing_dwellings_by_energy_efficiency_rating by santhosh-thangavel · Pull Request #140 · GSS-Cogs/idpd-api-poc

santhosh-thangavel · 2023-11-15T14:34:03Z

Editions and versions configuration files
Dataset.json configuration files

rossbowen · 2023-11-15T22:49:46Z

src/store/metadata/stub/content/datasets.json

          ]
+      },
+      {
+        "@id": "https://staging.idpd.uk/datasets/DLUHC",


Needs a globally unique identifier, something like epcs-for-existing-domestic-properties

set globally unique identifier as epcs-for-existing-domestic-properties

rossbowen · 2023-11-15T22:49:58Z

src/store/metadata/stub/content/datasets.json

+        "@id": "https://staging.idpd.uk/datasets/DLUHC",
+        "@type": "dcat:DatasetSeries",
+        "identifier": "existing_dwellings_data",
+        "title": "domestic Energy Performance Certificates for existing dwellings",


Needs to start with capital D

Changes it to capital D

rossbowen · 2023-11-15T22:50:16Z

src/store/metadata/stub/content/datasets.json

+        "next_release": "2024-01-26T09:30:00Z",
+        "publisher": "https://staging.idpd.uk/publishers/office-for-national-statistics",
+        "creator": "https://staging.idpd.uk/publishers/office-for-national-statistics",
+        "contact_point": {


JSON file needs to be formatted to have proper nesting

Proper formatting is done

rossbowen · 2023-11-15T22:52:07Z

...mance_certi_existing_dwellings_by_eng_eff_rating_2023_07/2023-07/existing_dwellings_data.csv

Make the header names snake_case

Drop the quarter/ from quarter/2010-Q3 etc.

If there's only a single measure type, then drop the measure type column

No URIs in CSV files, so drop unit of measure

changed column headers in snake_case

Removed quarter/ for all the rows in period column

Dropped Measure type column

Dropped unit column to avoid URIs in CSV files

rossbowen · 2023-11-15T22:53:47Z

src/store/metadata/stub/content/datasets.json

+        "modified": "2023-07-27T09:30:00Z",
+        "next_release": "2024-01-26T09:30:00Z",
+        "publisher": "https://staging.idpd.uk/publishers/office-for-national-statistics",
+        "creator": "https://staging.idpd.uk/publishers/office-for-national-statistics",


Change creator to DLUHC, so department-for-levelling-up-housing-and-communities

Changed as "creator": "https://staging.idpd.uk/publishers/department-for-levelling-up-housing-and-communities", but i am not very sure if this is what you mean

rossbowen · 2023-11-15T22:54:18Z

src/store/metadata/stub/content/datasets.json

+      {
+        "@id": "https://staging.idpd.uk/datasets/DLUHC",
+        "@type": "dcat:DatasetSeries",
+        "identifier": "existing_dwellings_data",


Change identifier to match the slug of the @id, so epcs-for-existing-domestic-properties

changed identifier as epcs-for-existing-domestic-propertie

rossbowen · 2023-11-15T22:54:47Z

...content/editions/domestic_energy_performance_certi_existing_dwellings_by_eng_eff_rating.json

@@ -0,0 +1,97 @@
+{
+    "@context": "https://staging.idpd.uk/#ns",
+    "@id": "https://staging.idpd.uk/datasets/DLUHC/editions",


Change this to use the same globally unique identifier as above

changed this to epcs-for-existing-domestic-properties

rossbowen · 2023-11-15T22:55:08Z

...content/editions/domestic_energy_performance_certi_existing_dwellings_by_eng_eff_rating.json

+    "title": "Domestic Energy Performance Certificates for existing dwellings",
+    "editions": [
+        {
+            "@id": "https://staging.idpd.uk/datasets/domestic_energy_performance_certi_existing_dwellings_by_eng_eff_rating_2023_07/editions/2023-10",


Change this to use the unique identifier, along with other instances throughout.

used epcs-for-existing-domestic-properties throughout

rossbowen · 2023-11-15T22:56:08Z

...content/editions/domestic_energy_performance_certi_existing_dwellings_by_eng_eff_rating.json

+                    "name": "Location",
+                    "datatype": "string",
+                    "titles": "Location",
+                    "description": "The name associated with The geography code "


Punctuate all descriptions, so they end in full stops.

Full stop at the end of all descriptions.

rossbowen · 2023-11-15T22:56:37Z

...ditions/versions/domestic_energy_performance_certi_existing_dwellings_by_eng_eff_rating.json

@@ -0,0 +1,65 @@
+{
+    "@context": "https://staging.idpd.uk/#ns",
+    "@id": "https://staging.idpd.uk/datasets/domestic_energy_performance_certi_existing_dwellings_by_eng_eff_rating_2023_07/editions/2023-07/versions",


Change to use globally unique identifier, and change all other instances too.

used epcs-for-existing-domestic-properties

santhosh-thangavel · 2023-11-17T16:27:51Z

@rossbowen Thanks for the PR comments. I have tried to resolve it. Happy to work on next batch of comments on this dataset.

santhosh-thangavel and others added 11 commits November 10, 2023 11:35

existing_dwellings_metadata

8acb348

changes to dates

11cf6bd

completed metadata part

300d65b

completed column configurations

dc22c50

changes to description

03a222f

completed adding metadata and column names as well

57e64bc

added csv and changes to config files

9539635

changes to column names

51e58ad

renamed and made changes to urls

29464da

Merge branch 'main' into santhosh/existing-dwellings

0a345c3

added metadata with new title

a1bff11

rossbowen suggested changes Nov 15, 2023

View reviewed changes

santhosh-thangavel added 5 commits November 17, 2023 11:45

Merge branch 'main' into santhosh/existing-dwellings

f29e02b

made changes to metadata

5ce9a45

deleted measure and unit column

6ddaa73

changes as per PR comments

1d2105d

deleting unwanted files

0117bf9

santhosh-thangavel added the data test case Tickets related to test case and examplar data for proof of concept label Nov 20, 2023

santhosh-thangavel and others added 11 commits November 21, 2023 09:59

changed topics and frequency

f579d44

Merge branch 'main' into santhosh/existing-dwellings

727b561

added topics and sub topics

a9f15f4

formatted all config files

e34df5f

made code changes to format a file when saved - prettier config included

ca8bca4

Merge branch 'main' into santhosh/existing-dwellings

6ab85c9

changed skos concept to dcat theme

8ae3e02

changed to capital C in Climate Change

a679604

changed the date

30eed56

Changed the modified date for versions file

9046860

Removed Z from time format

2d08e65

santhosh-thangavel added 2 commits December 4, 2023 12:02

added s in line 292

51efcc1

made changes to pass unit test

17e8246

Conversation

santhosh-thangavel commented Nov 15, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

santhosh-thangavel Nov 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

santhosh-thangavel commented Nov 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

santhosh-thangavel Nov 17, 2023 •

edited

Loading

santhosh-thangavel commented Nov 17, 2023 •

edited

Loading