additions to the housing stock 2 by rpm-data-dev · Pull Request #205 · GSS-Cogs/idpd-api-poc

rpm-data-dev · 2024-01-15T11:07:10Z

No description provided.

osamede20

Changes requested, mainly

changing 2022-2023 to 2023-05 on url's
changing name to snake_case everywhere
and the editions and versions file names need to be changed to end with 2023-05.json instead of 2022-2023.json inline with the file naming convention
Any other changes missed

Cheers.

osamede20 · 2024-01-16T10:40:14Z

src/store/metadata/stub/content/datasets.json

+      "editions_url": "https://staging.idpd.uk/datasets/additions-to-the-housing-stock/editions",
+      "editions": [
+        {
+          "@id": "https://staging.idpd.uk/datasets/additions-to-the-housing-stock/editions/2022-2023",


id should be : "https://staging.idpd.uk/datasets/additions-to-the-housing-stock/editions/2023-05"

osamede20 · 2024-01-16T10:41:41Z

src/store/metadata/stub/content/editions/additions-to-the-housing-stock_2022-2023.json

+  "title": "Net additions to the housing stock",
+  "editions": [
+    {
+      "@id": "https://staging.idpd.uk/datasets/additions-to-the-housing-stock/editions/2022-2023",


id should be: "https://staging.idpd.uk/datasets/additions-to-the-housing-stock/editions/2023-05"

osamede20 · 2024-01-16T10:43:29Z

src/store/metadata/stub/content/editions/additions-to-the-housing-stock_2022-2023.json

+      "@id": "https://staging.idpd.uk/datasets/additions-to-the-housing-stock/editions/2022-2023",
+      "@type": "dcat:Dataset",
+      "in_series": "https://staging.idpd.uk/datasets/additions-to-the-housing-stock",
+      "identifier": "2022-2023",


identifier should be: "2023-05"

(the year and month dataset was issued)

osamede20 · 2024-01-16T11:50:55Z

src/store/metadata/stub/content/editions/additions-to-the-housing-stock_2022-2023.json

+          "start": "2022-01-01T00:00:00Z",
+          "end": "2023-12-31T00:00:00Z"
+        },
+      "versions_url": "https://staging.idpd.uk/datasets/additions-to-the-housing-stock/editions/2022-2023/versions",


2022-2023 should be replaced with 2023-05 on the url

osamede20 · 2024-01-16T11:51:17Z

src/store/metadata/stub/content/editions/additions-to-the-housing-stock_2022-2023.json

+      "versions_url": "https://staging.idpd.uk/datasets/additions-to-the-housing-stock/editions/2022-2023/versions",
+      "versions": [
+        {
+          "@id": "https://staging.idpd.uk/datasets/additions-to-the-housing-stock/editions/2022-2023/versions/1",


2022-2023 should be replaced with 2023-05 on the url

osamede20 · 2024-01-16T12:26:28Z

src/store/metadata/stub/content/editions/additions-to-the-housing-stock_2022-2023.json

+                  "description": "Unit Type of the Observational Value"
+                },
+              {
+              "name": "Lower Confidence Interval (95%)",


should be snake_case, like in apprenticeships-achievements_2023-05.json
"name": "lower_confidence_interval_95",

osamede20 · 2024-01-16T12:27:56Z

src/store/metadata/stub/content/editions/additions-to-the-housing-stock_2022-2023.json

+            },
+            {
+                "name": "Observation",
+                "datatype": "integer",


datatype should be "decimal", like in apprenticeships-achievements_2023-05.json

osamede20 · 2024-01-16T12:29:56Z

src/store/metadata/stub/content/publishers.json

+        {
+            "@id": "https://staging.idpd.uk/publishers/department-for-levelling-up-housing-and-communities",
+            "@type": "dcat:publisher",
+            "title": "Department For Levelling Up Housing And Communities",


"title": "Department For Levelling Up, Housing And Communities",

osamede20 · 2024-01-16T12:34:18Z

src/store/metadata/stub/content/datasets.json

+      ],
+      "licence": "http://www.nationalarchives.gov.uk/doc/open-government-licence/version/3/",
+      "spatial_resolution": [
+        "E92000001","E12000001","E06000047","E06000005","E06000001","E06000002","E06000057","E06000003","E06000004","E11000007","E08000037","E08000021","E08000022","E08000023","E08000024","E12000002","E06000008","E06000009","E06000049","E06000050","E06000006","E06000007","E10000006","E07000026","E07000027","E07000028","E07000029","E07000030","E07000031","E11000001","E08000001","E08000002","E08000003","E08000004","E08000005","E08000006","E08000007","E08000008","E08000009","E08000010","E10000017","E07000117","E07000118","E07000119","E07000120","E07000121","E07000122","E07000123","E07000124","E07000125","E07000126","E07000127","E07000128","E11000002","E08000011","E08000012","E08000014","E08000013","E08000015","E12000003","E06000011","E06000010","E06000012","E06000013","E06000014","E10000023","E07000163","E07000164","E07000165","E07000166","E07000167","E07000168","E07000169","E11000003","E08000016","E08000017","E08000018","E08000019","E11000006","E08000032","E08000033","E08000034","E08000035","E08000036","E12000004","E06000015","E06000016","E06000061","E06000018","E06000017","E06000062","E10000007","E07000032","E07000033","E07000034","E07000035","E07000036","E07000037","E07000038","E07000039","E10000018","E07000129","E07000130","E07000131","E07000132","E07000133","E07000134","E07000135","E10000019","E07000136","E07000137","E07000138","E07000139","E07000140","E07000141","E07000142","E10000024","E07000170","E07000171","E07000172","E07000173","E07000174","E07000175","E07000176","E12000005","E06000019","E06000051","E06000021","E06000020","E10000028","E07000192","E07000193","E07000194","E07000195","E07000196","E07000197","E07000198","E07000199","E10000031","E07000218","E07000219","E07000220","E07000221","E07000222","E11000005","E08000025","E08000026","E08000027","E08000028","E08000029","E08000030","E08000031","E10000034","E07000234","E07000235","E07000236","E07000237","E07000238","E07000239","E12000006","E06000055","E06000056","E06000032","E06000031","E06000033","E06000034","E10000003","E07000008","E07000009","E07000010","E07000011","E07000012","E10000012","E07000066","E07000067","E07000068","E07000069","E07000070","E07000071","E07000072","E07000073","E07000074","E07000075","E07000076","E07000077","E10000015","E07000095","E07000096","E07000242","E07000098","E07000099","E07000240","E07000243","E07000102","E07000103","E07000241","E10000020","E07000143","E07000144","E07000145","E07000146","E07000147","E07000148","E07000149","E10000029","E07000200","E07000244","E07000202","E07000203","E07000245","E12000007","E09000007","E09000001","E09000012","E09000013","E09000014","E09000019","E09000020","E09000022","E09000023","E09000025","E09000028","E09000030","E09000032","E09000033","E09000002","E09000003","E09000004","E09000005","E09000006","E09000008","E09000009","E09000010","E09000011","E09000015","E09000016","E09000017","E09000018","E09000021","E09000024","E09000026","E09000027","E09000029","E09000031","E12000008","E06000036","E06000043","E06000060","E06000046","E06000035","E06000042","E06000044","E06000038","E06000039","E06000045","E06000037","E06000040","E06000041","E10000011","E07000061","E07000062","E07000063","E07000064","E07000065","E10000014","E07000084","E07000085","E07000086","E07000087","E07000088","E07000089","E07000090","E07000091","E07000092","E07000093","E07000094","E10000016","E07000105","E07000106","E07000107","E07000108","E07000112","E07000109","E07000110","E07000111","E07000113","E07000114","E07000115","E07000116","E10000025","E07000177","E07000178","E07000179","E07000180","E07000181","E10000030","E07000207","E07000208","E07000209","E07000210","E07000211","E07000212","E07000213","E07000214","E07000215","E07000216","E07000217","E10000032","E07000223","E07000224","E07000225","E07000226","E07000227","E07000228","E07000229","E12000009","E06000022","E06000058","E06000023","E06000052","E06000059","E06000053","E06000024","E06000026","E06000025","E06000030","E06000027","E06000054","E10000008","E07000040","E07000041","E07000042","E07000043","E07000044","E07000045","E07000046","E07000047","E10000013","E07000078","E07000079","E07000080","E07000081","E07000082","E07000083","E10000027","E07000187","E07000188","E07000246","E07000189"


I believe we can shorten all these spatial_resolution above to:
"E0", "E1", "E9"

just like we have in some of the datasets that have been published to the staging platform - datasets.json

osamede20 · 2024-01-16T12:36:04Z

src/store/metadata/stub/content/editions/additions-to-the-housing-stock_2022-2023.json

+      "issued": "2023-05-05T08:59:11Z",
+      "modified": "2023-12-06T15:10:00Z",
+      "spatial_resolution": [
+          "E92000001","E12000001","E06000047","E06000005","E06000001","E06000002","E06000057","E06000003","E06000004","E11000007","E08000037","E08000021","E08000022","E08000023","E08000024","E12000002","E06000008","E06000009","E06000049","E06000050","E06000006","E06000007","E10000006","E07000026","E07000027","E07000028","E07000029","E07000030","E07000031","E11000001","E08000001","E08000002","E08000003","E08000004","E08000005","E08000006","E08000007","E08000008","E08000009","E08000010","E10000017","E07000117","E07000118","E07000119","E07000120","E07000121","E07000122","E07000123","E07000124","E07000125","E07000126","E07000127","E07000128","E11000002","E08000011","E08000012","E08000014","E08000013","E08000015","E12000003","E06000011","E06000010","E06000012","E06000013","E06000014","E10000023","E07000163","E07000164","E07000165","E07000166","E07000167","E07000168","E07000169","E11000003","E08000016","E08000017","E08000018","E08000019","E11000006","E08000032","E08000033","E08000034","E08000035","E08000036","E12000004","E06000015","E06000016","E06000061","E06000018","E06000017","E06000062","E10000007","E07000032","E07000033","E07000034","E07000035","E07000036","E07000037","E07000038","E07000039","E10000018","E07000129","E07000130","E07000131","E07000132","E07000133","E07000134","E07000135","E10000019","E07000136","E07000137","E07000138","E07000139","E07000140","E07000141","E07000142","E10000024","E07000170","E07000171","E07000172","E07000173","E07000174","E07000175","E07000176","E12000005","E06000019","E06000051","E06000021","E06000020","E10000028","E07000192","E07000193","E07000194","E07000195","E07000196","E07000197","E07000198","E07000199","E10000031","E07000218","E07000219","E07000220","E07000221","E07000222","E11000005","E08000025","E08000026","E08000027","E08000028","E08000029","E08000030","E08000031","E10000034","E07000234","E07000235","E07000236","E07000237","E07000238","E07000239","E12000006","E06000055","E06000056","E06000032","E06000031","E06000033","E06000034","E10000003","E07000008","E07000009","E07000010","E07000011","E07000012","E10000012","E07000066","E07000067","E07000068","E07000069","E07000070","E07000071","E07000072","E07000073","E07000074","E07000075","E07000076","E07000077","E10000015","E07000095","E07000096","E07000242","E07000098","E07000099","E07000240","E07000243","E07000102","E07000103","E07000241","E10000020","E07000143","E07000144","E07000145","E07000146","E07000147","E07000148","E07000149","E10000029","E07000200","E07000244","E07000202","E07000203","E07000245","E12000007","E09000007","E09000001","E09000012","E09000013","E09000014","E09000019","E09000020","E09000022","E09000023","E09000025","E09000028","E09000030","E09000032","E09000033","E09000002","E09000003","E09000004","E09000005","E09000006","E09000008","E09000009","E09000010","E09000011","E09000015","E09000016","E09000017","E09000018","E09000021","E09000024","E09000026","E09000027","E09000029","E09000031","E12000008","E06000036","E06000043","E06000060","E06000046","E06000035","E06000042","E06000044","E06000038","E06000039","E06000045","E06000037","E06000040","E06000041","E10000011","E07000061","E07000062","E07000063","E07000064","E07000065","E10000014","E07000084","E07000085","E07000086","E07000087","E07000088","E07000089","E07000090","E07000091","E07000092","E07000093","E07000094","E10000016","E07000105","E07000106","E07000107","E07000108","E07000112","E07000109","E07000110","E07000111","E07000113","E07000114","E07000115","E07000116","E10000025","E07000177","E07000178","E07000179","E07000180","E07000181","E10000030","E07000207","E07000208","E07000209","E07000210","E07000211","E07000212","E07000213","E07000214","E07000215","E07000216","E07000217","E10000032","E07000223","E07000224","E07000225","E07000226","E07000227","E07000228","E07000229","E12000009","E06000022","E06000058","E06000023","E06000052","E06000059","E06000053","E06000024","E06000026","E06000025","E06000030","E06000027","E06000054","E10000008","E07000040","E07000041","E07000042","E07000043","E07000044","E07000045","E07000046","E07000047","E10000013","E07000078","E07000079","E07000080","E07000081","E07000082","E07000083","E10000027","E07000187","E07000188","E07000246","E07000189"


I believe we can shorten all these spatial_resolution above to:
"E0", "E1", "E9"

just like we have in some of the datasets that have been published to the staging platform - datasets.json

…S-Cogs/idpd-api-poc into rich_additions-to-the-housing-stock_2

osamede20 · 2024-01-29T10:58:09Z

src/store/metadata/stub/content/datasets.json

+      "identifier": "additions-to-the-housing-stock",
+      "title": "Net additions to the housing stock",
+      "summary": "Net additions to the dwelling stock (including new builds, conversions, changes of use, other gains/losses and offset by demolitions) per 1,000 stock, England, financial year 2022 - 2023.",
+      "description": "This dataset shows the net additions to the dwelling stock (including new builds, conversions, changes of use, other gains/losses and offset by demolitions) per 1,000 stock, in England, for financial year 2022 - 2023.\n\n### Coverage \n\nEngland\n\n#### Geography definition\n\nLocal Authority Districts and Unitary Authorities,\nCounties,\nMetropolitan Counties,\nNation (England) \n\n### Source\n\n - England: [Department for Levelling Up, Housing and Communities",


I missed this last time.
Please remove \n\n### Coverage \n\nEngland\n\n#### Geography definition\n\nLocal Authority Districts and Unitary Authorities,\nCounties,\nMetropolitan Counties,\nNation (England) \n\n### Source\n\n - England: [Department for Levelling Up, Housing and Communities from description. This wil come under Coverage on the platform

osamede20 · 2024-01-29T11:30:04Z

src/store/metadata/stub/content/datasets.json

+      "issued": "2023-05-05T08:59:11Z",
+      "modified": "2023-12-06T15:10:00Z",
+      "next_release": "2024-04-19T09:30:00Z",
+      "publisher": "https://staging.idpd.uk/publishers/department-for-levelling-up-housing-and-communities",


Please change to "https://staging.idpd.uk/publishers/office-for-national-statistics"

osamede20 · 2024-01-29T11:33:05Z

src/store/metadata/stub/content/editions/additions-to-the-housing-stock_2023-05.json

+      "identifier": "2023-05",
+      "title": "Net additions to the housing stock for 2022 to 2023",
+      "summary": "Net additions to the dwelling stock (including new builds, conversions, changes of use, other gains/losses and offset by demolitions) per 1,000 stock, England, financial year 2022 - 2023.",
+      "description": "This dataset shows the net additions to the dwelling stock (including new builds, conversions, changes of use, other gains/losses and offset by demolitions) per 1,000 stock, in England, for financial year 2022 - 2023.\n\n### Coverage \n\nEngland\n\n#### Geography definition\n\nLocal Authority Districts and Unitary Authorities,\nCounties,\nMetropolitan Counties,\nNation (England) \n\n### Source\n\n - England: [Department for Levelling Up, Housing and Communities]",


Please remove \n\n### Coverage \n\nEngland\n\n#### Geography definition\n\nLocal Authority Districts and Unitary Authorities,\nCounties,\nMetropolitan Counties,\nNation (England) \n\n### Source\n\n - England: [Department for Levelling Up, Housing and Communities]

This will come under Coverage.

osamede20 · 2024-01-29T11:37:55Z

src/store/metadata/stub/content/editions/additions-to-the-housing-stock_2023-05.json

+      "title": "Net additions to the housing stock for 2022 to 2023",
+      "summary": "Net additions to the dwelling stock (including new builds, conversions, changes of use, other gains/losses and offset by demolitions) per 1,000 stock, England, financial year 2022 - 2023.",
+      "description": "This dataset shows the net additions to the dwelling stock (including new builds, conversions, changes of use, other gains/losses and offset by demolitions) per 1,000 stock, in England, for financial year 2022 - 2023.\n\n### Coverage \n\nEngland\n\n#### Geography definition\n\nLocal Authority Districts and Unitary Authorities,\nCounties,\nMetropolitan Counties,\nNation (England) \n\n### Source\n\n - England: [Department for Levelling Up, Housing and Communities]",
+      "publisher": "https://staging.idpd.uk/publishers/department-for-levelling-up-housing-and-communities",


"https://staging.idpd.uk/publishers/office-for-national-statistics"

osamede20 · 2024-01-29T11:43:05Z

src/store/metadata/stub/content/editions/additions-to-the-housing-stock_2023-05.json

+          {
+              "name": "period",
+              "datatype": "string",
+              "titles": "gregorian-interval",


Please change to "Government Year"

A good reference is the published dataset on PMD-Beta

osamede20 · 2024-01-29T11:45:40Z

src/store/metadata/stub/content/editions/additions-to-the-housing-stock_2023-05.json

+            {
+              "name": "areacd",
+              "datatype": "string",
+              "titles": "Statistical Geography",


Change to "ONS Geography Code"

osamede20 · 2024-01-29T11:52:03Z

src/store/metadata/stub/content/editions/additions-to-the-housing-stock_2023-05.json

+              "description": "The categorisation of the geography code"
+            },
+            {
+              "name": "variable_name",


Please remove the column mappings for
variable_name
indicator
mission
category
polarity
notes

Reasons:

They are set to false on https://github.com/GSS-Cogs/family-ess/blob/main/additions-to-the-housing-stock/additions-to-the-housing-stock.json

There is a maximum number of columns that can be supported by the idpd-poc platform

osamede20 · 2024-01-29T11:54:22Z

src/store/metadata/stub/content/editions/versions/additions-to-the-housing-stock_2023-05.json

+            "issued": "2023-05-05T08:59:11Z",
+            "title": "Net additions to the housing stock",
+            "summary": "Net additions to the dwelling stock (including new builds, conversions, changes of use, other gains/losses and offset by demolitions) per 1,000 stock, England, financial year 2022 - 2023.",
+            "description": "This dataset shows the net additions to the dwelling stock (including new builds, conversions, changes of use, other gains/losses and offset by demolitions) per 1,000 stock, in England, for financial year 2022 - 2023.\n\n### Coverage \n\nEngland\n\n#### Geography definition\n\nLocal Authority Districts and Unitary Authorities,\nCounties,\nMetropolitan Counties,\nNation (England) \n\n### Source\n\n - England: [Department for Levelling Up, Housing and Communities]",


Please effect all the changes requested for the editions file (above) on the versions file as well

rpm-data-dev added 10 commits January 9, 2024 15:57

started editions file

00a6c27

empty version file

8a211a2

editions file filled

84ebbff

added additions to dataset.json

764d508

had to shorten description length

68edd84

added housing publisher

554f8a3

rm modified field, changed topic

849538f

version 1

1e038eb

added csv

2e2f759

moved csv file

f82a060

rpm-data-dev requested a review from osamede20 January 15, 2024 11:43

Merge branch 'main' into rich_additions-to-the-housing-stock_2

6804c4e

mikeAdamss added the data test case Tickets related to test case and examplar data for proof of concept label Jan 15, 2024

osamede20 suggested changes Jan 16, 2024

View reviewed changes

rpm-data-dev added 2 commits January 19, 2024 09:18

more corrections made

945a2dd

Merge branch 'rich_additions-to-the-housing-stock_2' of github.com:GS…

372f5ec

…S-Cogs/idpd-api-poc into rich_additions-to-the-housing-stock_2

rpm-data-dev requested a review from osamede20 January 19, 2024 09:22

osamede20 changed the title ~~Rich additions to the housing stock 2~~ additions to the housing stock 2 Jan 29, 2024

osamede20 suggested changes Jan 29, 2024

View reviewed changes

Conversation

rpm-data-dev commented Jan 15, 2024

Uh oh!

osamede20 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants