Conversation
changed spatial resolution as directed
changed spatial resolution as directed
rpm-data-dev
added
the
data test case
osamede20
left a comment
osamede20
left a comment
There was a problem hiding this comment.
Changes requested for datasets.json, editions and versions file
| "identifier": "adult-obesity-prevalence-aged-18-years-and-over", | ||
| "title": "Adult obesity prevalence (aged 18 years and over)", | ||
| "summary": "Percentage of adults aged 18 and over classified as living with obesity, England, 16/11/2015-15/11/2016 to 16/11/2021-15/11/2022.", | ||
| "description": "Percentage of adults aged 18 and over classified as living with obesity, in England, for 16/11/2015-15/11/2016 to 16/11/2021-15/11/2022.\n\nCoverage\nEngland\n\nGeography definition\nLocal Authority Districts and Unitary Authorities,\nCounties,\nRegions,\nCombined Authorities,\nNation (England)\n\nSource\nEngland: [Office for Health Improvement and Disparities]\n\nSource Notes and Caveats\nAdults are defined as obese if their body mass index (BMI) is greater than or equal to 30kg/m²", |
There was a problem hiding this comment.
Please remove
\n\nCoverage\nEngland\n\nGeography definition\nLocal Authority Districts and Unitary Authorities,\nCounties,\nRegions,\nCombined Authorities,\nNation (England)\n\nSource\nEngland: [Office for Health Improvement and Disparities]\n\nSource Notes and Caveats\nAdults are defined as obese if their body mass index (BMI) is greater than or equal to 30kg/m²"
That will come under Coverage in the staging platform.
| "identifier": "2023-05", | ||
| "title": "Adult obesity prevalence (aged 18 years and over)", | ||
| "summary": "Percentage of adults aged 18 and over classified as living with obesity, England, 16/11/2015-15/11/2016 to 16/11/2021-15/11/2022.", | ||
| "description": "Percentage of adults aged 18 and over classified as living with obesity, in England, for 16/11/2015-15/11/2016 to 16/11/2021-15/11/2022.\n\nCoverage\nEngland\n\nGeography definition\nLocal Authority Districts and Unitary Authorities,\nCounties,\nRegions,\nCombined Authorities,\nNation (England)\n\nSource\nEngland: [Office for Health Improvement and Disparities]\n\nSource Notes and Caveats\nAdults are defined as obese if their body mass index (BMI) is greater than or equal to 30kg/m²", |
There was a problem hiding this comment.
Please remove this:
s,\nCounties,\nRegions,\nCombined Authorities,\nNation (England)\n\nSource\nEngland: [Office for Health Improvement and Disparities]\n\nSource Notes and Caveats\nAdults are defined as obese if their body mass index (BMI) is greater than or equal to 30kg/m²".
That will come under Coverage in the staging platform.
| { | ||
| "name": "areacd", | ||
| "datatype": "string", | ||
| "titles": "Statistical Geography", |
There was a problem hiding this comment.
Please change to "ONS Geography Code"
| { | ||
| "name": "measure", | ||
| "datatype": "string", | ||
| "titles": "Measure Type", |
| { | ||
| "name": "unit", | ||
| "datatype": "string", | ||
| "titles": "Unit", |
| "name": "unit", | ||
| "datatype": "string", | ||
| "titles": "Unit", | ||
| "description": "Unit Type of the Observational Value" |
There was a problem hiding this comment.
Change to: "Unit type of the observation value"
| "titles": "Observation Status", | ||
| "description": "Additional Context to the Observation if needed" | ||
| }, | ||
| { |
There was a problem hiding this comment.
Please delete polarity and notes column mappings.
They are set to false on the json file on family-ess repo and they are not displayed on the PMD-Beta site, for which both links are indicated earlier
| { | ||
| "name": "period", | ||
| "datatype": "string", | ||
| "titles": "gregorian-interval", |
There was a problem hiding this comment.
Please change to "Gregorian Time Interval". Titles are usually title case.
"from_template": "gregorian-interval" on the json file on family-ess repo only indicates that the gregorian-interval template was used in the csvcubed transform.
Here is a reference to check the titles:
https://beta.gss-data.org.uk/cube/explore?uri=https%3A%2F%2Fgss-cogs.github.io%2Ffamily-ess%2Fout%2Fadult-obesity-prevalence-aged-18-years-and-over%2Fadult-obesity-prevalence-aged-18-years-and-over%2Fadult-obesity-prevalence-aged-18-years-and-over.csv%23dataset-catalog-entry
| "titles": "Geography Type", | ||
| "description": "The categorisation of the geography code" | ||
| }, | ||
| { |
There was a problem hiding this comment.
Please delete the column mapping for: variable_name, indicator, mission, category.
They are set to false in the json file on the family-ess repo:
| "issued": "2023-05-17T12:41:00Z", | ||
| "title": "Adult obesity prevalence (aged 18 years and over)", | ||
| "summary": "Percentage of adults aged 18 and over classified as living with obesity, England, 16/11/2015-15/11/2016 to 16/11/2021-15/11/2022.", | ||
| "description": "Percentage of adults aged 18 and over classified as living with obesity, in England, for 16/11/2015-15/11/2016 to 16/11/2021-15/11/2022.\n\nCoverage\nEngland\n\nGeography definition\nLocal Authority Districts and Unitary Authorities,\nCounties,\nRegions,\nCombined Authorities,\nNation (England)\n\nSource\nEngland: [Office for Health Improvement and Disparities]\n\nSource Notes and Caveats\nAdults are defined as obese if their body mass index (BMI) is greater than or equal to 30kg/m²", |
There was a problem hiding this comment.
Please implement all the changes requested for the editions file on the versions file as well.
2 participants
No description provided.