You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR fixes a bug in convertDbBucket where file properties (path, configId, bucketName, configEnv) were incorrectly nested inside a fileId key instead of being spread directly onto the FileIdentifier object. The IdentifierProto.FileIdentifier interface defines these as top-level fields, so the old code produced structurally wrong objects that would not satisfy the proto contract at runtime.
Confidence Score: 5/5
Safe to merge — focused, correct bug fix with no new issues introduced.
The change is a minimal, targeted correction that aligns the object mapping with the actual FileIdentifier proto interface. All four mapped fields match the interface exactly, and the removal of the spurious as IdentifierProto.FileIdentifier type assertion (which was masking the shape error) is also correct. No new logic, no side effects, and no custom rule violations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.