Skip to content

fixed convert db bug#253

Merged
llam36 merged 1 commit intomainfrom
akash/convert-db-bug
Apr 12, 2026
Merged

fixed convert db bug#253
llam36 merged 1 commit intomainfrom
akash/convert-db-bug

Conversation

@KashGiannis34
Copy link
Copy Markdown
Collaborator

No description provided.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 12, 2026

Greptile Summary

This PR fixes a bug in convertDbBucket where file properties (path, configId, bucketName, configEnv) were incorrectly nested inside a fileId key instead of being spread directly onto the FileIdentifier object. The IdentifierProto.FileIdentifier interface defines these as top-level fields, so the old code produced structurally wrong objects that would not satisfy the proto contract at runtime.

Confidence Score: 5/5

Safe to merge — focused, correct bug fix with no new issues introduced.

The change is a minimal, targeted correction that aligns the object mapping with the actual FileIdentifier proto interface. All four mapped fields match the interface exactly, and the removal of the spurious as IdentifierProto.FileIdentifier type assertion (which was masking the shape error) is also correct. No new logic, no side effects, and no custom rule violations.

No files require special attention.

Important Files Changed

Filename Overview
packages/db-service/src/modules/file_bucket/file_bucket.service.ts Fixes incorrect fileId nesting in convertDbBucket — properties are now mapped directly onto FileIdentifier matching the proto interface definition.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["DB Query Result: bucket.FileServiceFile"] -->|map| B["convertDbBucket"]
    B -->|Before fix| C["fileId nested object - Wrong shape"]
    B -->|After fix| D["path, configId, bucketName, configEnv - Correct FileIdentifier shape"]
    D --> E["FileBucketProto.Bucket returned to gRPC caller"]
Loading

Reviews (1): Last reviewed commit: "fixed convert db bug" | Re-trigger Greptile

@llam36 llam36 merged commit bd79e3e into main Apr 12, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants