-
Notifications
You must be signed in to change notification settings - Fork 46
Excaliber And Flugel eye. #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…o build 1.7.10-209 Assets and teleportations functional, still need to fix the text overlay for distance/teleport name.
…n as an actual Relic.
…aliber to Dice Pool.
|
How do you get seven items from six-sided Dice of Fate? |
By changing the range for dice drops from 0-5 to 0-6 💀 |
|
Dice pool doesn't seem to actually be working 💀 |
|
Important to note that the Alfheim mod does the same thing, causing an incompatibility when loaded together. |
|
@Shahelion @thenextelement maybe when Botania is integrated better we can think of add Alfheim also |
|
Turns out the main conflict comes from Alfheim overwriting the ItemDice code to give random loot instead of nothing when it lands on a number that's already been hit. The Flugel Eye and Excalibur are implemented as separate items, so that part's fine. There are quite a few users who are using both Alfheim and the GTNH fork of Botania, based on what I've seen so far, especially since Botania is in the Active Support category. Maybe just a config to disable this, or auto-disable if Alfheim is present? |



[Unrelated botania change] Updated the link for witchery wiki to This
The Holy sword Excaliber is working again and will drop from a normal Dice roll.
Flugel Teleportation works with all 12 locations as it did in Botania 1.7.10-208 and earlier, ̶
b̶u̶t̶ ̶s̶t̶i̶l̶l̶ ̶n̶e̶e̶d̶ ̶t̶o̶ ̶f̶i̶g̶u̶r̶e̶ ̶o̶u̶t̶ ̶h̶o̶w̶ ̶t̶o̶ ̶g̶e̶t̶ ̶t̶h̶e̶ ̶D̶i̶s̶t̶a̶n̶c̶e̶ ̶f̶r̶o̶m̶ ̶w̶a̶r̶p̶ ̶l̶o̶c̶a̶t̶i̶o̶n̶s̶/̶n̶a̶m̶e̶s̶ ̶o̶f̶ ̶t̶h̶e̶ ̶w̶a̶r̶p̶ ̶l̶o̶c̶a̶t̶i̶o̶n̶s̶ ̶f̶u̶n̶c̶t̶i̶o̶n̶a̶l̶ ̶a̶g̶a̶i̶n̶.̶~ Fixed :DI was only going to PR the wiki update, but have been working on this for my own pack and was requested to PR by Brandyn.
https://github.com/VazkiiMods/Botania/blob/67ae60a5f591c39fe1df81eebec0c094c639671f/src/main/java/vazkii/botania/common/item/relic/ItemFlugelEye.java
Linked is the eye of the flugel code as it was in build 208 of Botania.