Added Saveable Schematics for the Ring of Loki

[ReignOfFROZE]

This PR adds saveable schematics for the Ring of Loki, adding keybinds to:

• Save a schematic
• Open the schematic management UI

The schematic management UI is the UI you will use to manage your schematics (as the name implies), allowing you to select the schematic you want to use, change the names of schematics, and delete existing schematics.

Other than that, it's a fairly straightforward change, and doesn't add any real functionality to loki, just some QoL that makes loki a bit easier to use.

Demo

Quick note: I am NOT attached to the icons or background that are included in this PR, and if anyone has alternatives they'd like to create/offer, I'm 100% on board with anything that you think may fit the aesthetic of Botania more, these were some I just pulled together in like 5 minutes.

It also should be noted this was my first time ever making a UI with any UI framework, not just MUI, so this UI code is probably absolutely terrible and if anyone smarter than I has comments, feel free to rip it apart.

[glowredman]

I can't say much about how well ModularUI is used here, however I have a few points:

• If you want to use ModularUI: make this feature optional. At the moment, ModularUI is introduced as a hard-dep (and not even declared as one). Botania is listed as active support, so introducing new deps must have a good reason. A cleaner solution (although quite some work) would be reimplementing the GUI without ModularUI.
• The textures are to high-res. The files are way to big and the textures don't fit in with MC's style and are to detailed for the size they are displayed at.

[miozune]

Reimplementing GUI with vanilla is quite painful and kills the point in using library. Making it no-op when MUI is missing would be good.
And as I mentioned on Discord, please use MUI2 instead. I understand it's not fun to port things, but we need to move forward for deprecating MUI1.

[ReignOfFROZE]

The UI has been migrated to MUI2, the icons have been swapped for 16x16 icons, and I added method stripping and conditional checks to make sure that MUI is loaded for anything relating to the management UI.

Changes requested were made, can't say much about the GUI code.

[YannickMG]

I pushed an extra commit to GTNewHorizons:Botania:feature/schematics-refactor which handles visually adapting the schematics list when an item is removed. I don't mean to take over your PR, but I also didn't want to ask you to do something I didn't know a way of doing myself.

[combusterf]

My main concern with this is that this repository is meant to function like base Botania with better modding options. If we substantially want to deviate with that (i.e. turn the ring of Loki into a big multitool, and adding UI to a mod that has by design refused to do so) then it would have been better to add such functionality to BotanicHorizons

[ReignOfFROZE]

My main concern with this is that this repository is meant to function like base Botania with better modding options. If we substantially want to deviate with that (i.e. turn the ring of Loki into a big multitool, and adding UI to a mod that has by design refused to do so) then it would have been better to add such functionality to BotanicHorizons

I don't think this turns the ring of Loki into a big multi tool, it just adds some QoL to it. Additionally, the ring of Loki isn't from base Botania either, so I'd say we've already thrown base Botania's ideology out the window as it is.

Also, it wouldn't really be feasible to add all of this to BotanicHorizons unless you were to just add a ton of mixins to interact with the item class.

[YannickMG]

Interop is 100% possible without mixins if you add a proper API. That being said if this UI can be locked behind a config then there is no harm to those who want to play without it.

[ReignOfFROZE]

Interop is 100% possible without mixins if you add a proper API. That being said if this UI can be locked behind a config then there is no harm to those who want to play without it.

It already is locked behind having MUI enabled on your instance (as well as having the keybinds bound), which I feel like is plenty of gating for experiences outside of NH as well as within NH

[YannickMG]

I will note that by now MUI2 has been through a few breaking changes and the method collapseDisabledChild makes it much easier to avoid having holes in the list without resorting to the hacky workaround I proposed.

My code was used, though it's not the best anymore since MUI2 has changed since.

[YannickMG]

On the latest version one of the keybind language keys is wrong.

Also I couldn't rename any schematics. It's quite possible the overcomplication which I used in my suggested code prior to the addition of collapseDisabledChild is part of the cause.

[Dream-Master]

@combusterf are other changes are needed ?

[boubou19]

@combusterf @ReignOfFROZE any news about this PR?